mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
1e86fdcea8
## Issue We want to discard-but-remember any slots that aren't a perfect fit, on the off chance that a better one exists later in the search space. If there's no better match, then we gotta go with what we got. ## Example: Wurmple exists in area `X`, and also has a more rare slot for Silcoon, with the same level for both slots. * We have a Silcoon that we've leveled up a few times. Was our Silcoon originally a Wurmple, or was it caught as a Silcoon? * To be sure, we have to check the EC/PID if the Wurmple wouldn't evolve into Cascoon instead. * We don't want to wholly reject that Wurmple slot, as maybe the Met Level isn't within Silcoon's slot range. --- Existing implementation would store "deferred" matches in a list; we only need to keep 1 of these matches around (less allocation!). We also want to differentiate between a "good" deferral and a "bad" deferral; I don't think this is necessary but it's currently used by Mystery Gift matching (implemented for the Eeveelution mystery gifts which matter for evolution moves). The existing logic didn't use inheritance, and instead had static methods being reused across generations. Quite kludgy. Also, the existing logic was a pain to modify the master encounter yield methods, as one generation's quirks had to not impact all other generations that used the method. --- The new implementation splits out the encounter yielding methods to be separate for each generation / subset. Now, things don't have to check `WasLink` for Gen7 origin, because Pokémon Link wasn't a thing in Gen7. --- ## Future Maybe refactoring yielders into "GameCores" that expose yielding behaviors / properties, rather than the static logic. As more generations and side-gamegroups get added (thanks LGPE/GO/GameCube), all this switch stuff gets annoying to maintain instead of just overriding/inheritance. ## Conclusion This shouldn't impact any legality results negatively; if you notice any regressions, report them! This should reduce false flags where we didn't defer-discard an encounter when we should have (wild area mons being confused with raids).
130 lines
4 KiB
C#
130 lines
4 KiB
C#
using System;
|
|
using System.Linq;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Generation 2 Static Encounter
|
|
/// </summary>
|
|
/// <inheritdoc cref="EncounterStatic"/>
|
|
public record EncounterStatic2 : EncounterStatic
|
|
{
|
|
public sealed override int Generation => 2;
|
|
public sealed override int Level { get; init; }
|
|
|
|
public EncounterStatic2(int species, int level, GameVersion game) : base(game)
|
|
{
|
|
Species = species;
|
|
Level = level;
|
|
}
|
|
|
|
protected override bool IsMatchEggLocation(PKM pkm)
|
|
{
|
|
if (pkm.Format > 2)
|
|
return true;
|
|
|
|
if (pkm.IsEgg)
|
|
{
|
|
if (!EggEncounter)
|
|
return false;
|
|
if (pkm.Met_Location != 0 && pkm.Met_Level != 0)
|
|
return false;
|
|
if (pkm.OT_Friendship > EggCycles) // Dizzy Punch eggs start with below-normal hatch counters.
|
|
return false;
|
|
}
|
|
else
|
|
{
|
|
switch (pkm.Met_Level)
|
|
{
|
|
case 0 when pkm.Met_Location != 0:
|
|
return false;
|
|
case 1 when pkm.Met_Location == 0:
|
|
return false;
|
|
default:
|
|
if (pkm.Met_Location == 0 && pkm.Met_Level != 0)
|
|
return false;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
protected override void SetMetData(PKM pk, int level, DateTime today)
|
|
{
|
|
if (Version != GameVersion.C)
|
|
return;
|
|
var pk2 = (PK2)pk;
|
|
pk2.Met_Location = Location;
|
|
pk2.Met_Level = level;
|
|
pk2.Met_TimeOfDay = EncounterTime.Any.RandomValidTime();
|
|
}
|
|
|
|
protected override bool IsMatchLevel(PKM pkm, DexLevel evo)
|
|
{
|
|
if (pkm is ICaughtData2 {CaughtData: not 0})
|
|
return pkm.Met_Level == (EggEncounter ? 1 : Level);
|
|
|
|
return Level <= evo.Level;
|
|
}
|
|
|
|
protected override bool IsMatchLocation(PKM pkm)
|
|
{
|
|
if (EggEncounter)
|
|
return true;
|
|
if (Location == 0)
|
|
return true;
|
|
if (pkm is ICaughtData2 {CaughtData: not 0})
|
|
return Location == pkm.Met_Location;
|
|
return true;
|
|
}
|
|
|
|
protected override bool IsMatchPartial(PKM pkm) => false;
|
|
}
|
|
|
|
public sealed record EncounterStatic2Odd : EncounterStatic2
|
|
{
|
|
private const int Dizzy = 146;
|
|
private static readonly int[] _dizzy = { Dizzy };
|
|
|
|
public EncounterStatic2Odd(int species) : base(species, 5, GameVersion.C)
|
|
{
|
|
Moves = _dizzy;
|
|
EggLocation = 256;
|
|
EggCycles = 20;
|
|
}
|
|
|
|
public override bool IsMatchExact(PKM pkm, DexLevel evo)
|
|
{
|
|
// Let it get picked up as regular EncounterEgg under other conditions.
|
|
if (pkm.Format > 2)
|
|
return false;
|
|
if (!pkm.HasMove(Dizzy))
|
|
return false;
|
|
if (pkm.IsEgg && pkm.EXP != 125)
|
|
return false;
|
|
return base.IsMatchExact(pkm, evo);
|
|
}
|
|
}
|
|
|
|
public sealed record EncounterStatic2Roam : EncounterStatic2
|
|
{
|
|
private static readonly int[] Roaming_MetLocation_GSC_Grass =
|
|
{
|
|
// Routes 29, 30-31, 33, 34, 35, 36-37, 38-39, 42, 43, 44, 45-46 can be encountered in grass
|
|
2, 4, 5, 8, 11, 15, 18, 20, 21,
|
|
25, 26, 34, 37, 39, 43, 45,
|
|
};
|
|
|
|
public override int Location => Roaming_MetLocation_GSC_Grass[0];
|
|
|
|
public EncounterStatic2Roam(int species, int level, GameVersion ver) : base(species, level, ver) { }
|
|
|
|
protected override bool IsMatchLocation(PKM pkm)
|
|
{
|
|
if (!pkm.HasOriginalMetLocation)
|
|
return true;
|
|
return Roaming_MetLocation_GSC_Grass.Contains(Location);
|
|
}
|
|
}
|
|
}
|