mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 06:20:25 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
73 lines
2.8 KiB
C#
73 lines
2.8 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Generation 5 <see cref="SaveFile"/> object for <see cref="GameVersion.B2W2"/>.
|
|
/// </summary>
|
|
/// <inheritdoc cref="SAV5" />
|
|
public sealed class SAV5B2W2 : SAV5, ISaveBlock5B2W2
|
|
{
|
|
public SAV5B2W2() : base(SaveUtil.SIZE_G5RAW)
|
|
{
|
|
Blocks = new SaveBlockAccessor5B2W2(this);
|
|
Initialize();
|
|
}
|
|
|
|
public SAV5B2W2(byte[] data) : base(data)
|
|
{
|
|
Blocks = new SaveBlockAccessor5B2W2(this);
|
|
Initialize();
|
|
}
|
|
|
|
public override PersonalTable Personal => PersonalTable.B2W2;
|
|
public SaveBlockAccessor5B2W2 Blocks { get; }
|
|
protected override SaveFile CloneInternal() => new SAV5B2W2((byte[]) Data.Clone());
|
|
protected override int EventConstMax => 0x1AF; // this doesn't seem right?
|
|
protected override int EventFlagMax => 0xBF8;
|
|
public override int MaxItemID => Legal.MaxItemID_5_B2W2;
|
|
|
|
private void Initialize()
|
|
{
|
|
BattleBoxOffset = 0x20900;
|
|
EventConst = 0x1FF00;
|
|
EventFlag = EventConst + 0x35E;
|
|
CGearInfoOffset = 0x1C000;
|
|
CGearDataOffset = 0x52800;
|
|
EntreeForestOffset = 0x22A00;
|
|
PokeDex = Blocks.Zukan.PokeDex;
|
|
WondercardData = Blocks.Mystery.Offset;
|
|
DaycareOffset = Blocks.Daycare.Offset;
|
|
}
|
|
|
|
public override IReadOnlyList<BlockInfo> AllBlocks => Blocks.BlockInfo;
|
|
public override MyItem Items => Blocks.Items;
|
|
public override Zukan5 Zukan => Blocks.Zukan;
|
|
public override Misc5 Misc => Blocks.Misc;
|
|
public override MysteryBlock5 Mystery => Blocks.Mystery;
|
|
public override Daycare5 Daycare => Blocks.Daycare;
|
|
public override BoxLayout5 BoxLayout => Blocks.BoxLayout;
|
|
public override PlayerData5 PlayerData => Blocks.PlayerData;
|
|
public override BattleSubway5 BattleSubway => Blocks.BattleSubway;
|
|
public override Entralink5 Entralink => Blocks.Entralink;
|
|
public override Musical5 Musical => Blocks.Musical;
|
|
public override Encount5 Encount => Blocks.Encount;
|
|
public FestaBlock5 Festa => Blocks.Festa;
|
|
public PWTBlock5 PWT => Blocks.PWT;
|
|
public override int Fused => 0x1FA00 + sizeof(uint);
|
|
public override int GTS => 0x20400;
|
|
|
|
public string Rival
|
|
{
|
|
get => GetString(Rival_Trash);
|
|
set => SetString(Rival_Trash, value.AsSpan(), OTLength, StringConverterOption.ClearZero);
|
|
}
|
|
|
|
public Span<byte> Rival_Trash
|
|
{
|
|
get => Data.AsSpan(0x23BA4, OTLength * 2);
|
|
set { if (value.Length == OTLength * 2) value.CopyTo(Data.AsSpan(0x23BA4)); }
|
|
}
|
|
}
|
|
}
|