mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-24 04:53:08 +00:00
02420d3e93
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
84 lines
2.6 KiB
C#
84 lines
2.6 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Windows.Forms;
|
|
using PKHeX.Core;
|
|
|
|
namespace PKHeX.WinForms.Subforms.Save_Editors
|
|
{
|
|
public partial class TrainerStat : UserControl
|
|
{
|
|
public TrainerStat() => InitializeComponent();
|
|
private bool Editing;
|
|
private ITrainerStatRecord SAV;
|
|
private Dictionary<int, string> RecordList; // index, description
|
|
public Func<int, string> GetToolTipText { private get; set; }
|
|
|
|
public void LoadRecords(ITrainerStatRecord sav, Dictionary<int, string> records)
|
|
{
|
|
SAV = sav;
|
|
RecordList = records;
|
|
CB_Stats.Items.Clear();
|
|
for (int i = 0; i < sav.RecordCount; i++)
|
|
{
|
|
if (!RecordList.TryGetValue(i, out string name))
|
|
name = $"{i:D3}";
|
|
|
|
CB_Stats.Items.Add(name);
|
|
}
|
|
CB_Stats.SelectedIndex = RecordList.First().Key;
|
|
}
|
|
|
|
private void ChangeStat(object sender, EventArgs e)
|
|
{
|
|
Editing = true;
|
|
int index = CB_Stats.SelectedIndex;
|
|
int val = SAV.GetRecord(index);
|
|
NUD_Stat.Maximum = Math.Max(val, SAV.GetRecordMax(index));
|
|
NUD_Stat.Value = val;
|
|
|
|
int offset = SAV.GetRecordOffset(index);
|
|
L_Offset.Text = $"Offset: 0x{offset:X3}";
|
|
UpdateTip(index, true);
|
|
Editing = false;
|
|
}
|
|
|
|
private void ChangeStatVal(object sender, EventArgs e)
|
|
{
|
|
if (Editing)
|
|
return;
|
|
int index = CB_Stats.SelectedIndex;
|
|
SAV.SetRecord(index, (int)NUD_Stat.Value);
|
|
UpdateTip(index, false);
|
|
}
|
|
|
|
private void UpdateTip(int index, bool updateStats)
|
|
{
|
|
if (GetToolTipText != null)
|
|
UpdateToolTipSpecial(index, updateStats);
|
|
else
|
|
UpdateToolTipDefault(index, updateStats);
|
|
}
|
|
|
|
private void UpdateToolTipSpecial(int index, bool updateStats)
|
|
{
|
|
var str = GetToolTipText(index);
|
|
if (str != null)
|
|
{
|
|
Tip.SetToolTip(NUD_Stat, str);
|
|
return;
|
|
}
|
|
UpdateToolTipDefault(index, updateStats); // fallback
|
|
}
|
|
|
|
private void UpdateToolTipDefault(int index, bool updateStats)
|
|
{
|
|
if (!updateStats || !RecordList.TryGetValue(index, out string tip))
|
|
{
|
|
Tip.RemoveAll();
|
|
return;
|
|
}
|
|
Tip.SetToolTip(CB_Stats, tip);
|
|
}
|
|
}
|
|
}
|