mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-24 19:33:10 +00:00
02420d3e93
* Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
156 lines
5.3 KiB
C#
156 lines
5.3 KiB
C#
using System;
|
|
using System.ComponentModel;
|
|
using System.Windows.Forms;
|
|
using PKHeX.Core;
|
|
|
|
using static PKHeX.Core.MessageStrings;
|
|
|
|
namespace PKHeX.WinForms.Controls
|
|
{
|
|
public partial class ContextMenuSAV : UserControl
|
|
{
|
|
public ContextMenuSAV() => InitializeComponent();
|
|
|
|
public SaveDataEditor<PictureBox> Editor { private get; set; }
|
|
public SlotChangeManager Manager { get; set; }
|
|
|
|
public event LegalityRequest RequestEditorLegality;
|
|
public delegate void LegalityRequest(object sender, EventArgs e, PKM pkm);
|
|
|
|
public void OmniClick(object sender, EventArgs e, Keys z)
|
|
{
|
|
switch (z)
|
|
{
|
|
case Keys.Control: ClickView(sender, e); break;
|
|
case Keys.Shift: ClickSet(sender, e); break;
|
|
case Keys.Alt: ClickDelete(sender, e); break;
|
|
default:
|
|
return;
|
|
}
|
|
|
|
// restart hovering since the mouse event isn't fired
|
|
Manager.MouseEnter(sender, e);
|
|
}
|
|
|
|
private void ClickView(object sender, EventArgs e)
|
|
{
|
|
var info = GetSenderInfo(ref sender);
|
|
if ((sender as PictureBox)?.Image == null)
|
|
{ System.Media.SystemSounds.Asterisk.Play(); return; }
|
|
|
|
Manager.Hover.Stop();
|
|
var pkm = Editor.Slots.Get(info.Slot);
|
|
Editor.PKMEditor.PopulateFields(pkm, false, true);
|
|
}
|
|
|
|
private void ClickSet(object sender, EventArgs e)
|
|
{
|
|
var editor = Editor.PKMEditor;
|
|
if (!editor.EditsComplete)
|
|
return;
|
|
PKM pk = editor.PreparePKM();
|
|
|
|
var info = GetSenderInfo(ref sender);
|
|
var sav = info.View.SAV;
|
|
|
|
if (!CheckDest(info, sav, pk))
|
|
return;
|
|
|
|
var errata = sav.IsPKMCompatible(pk);
|
|
if (errata.Count > 0 && DialogResult.Yes != WinFormsUtil.Prompt(MessageBoxButtons.YesNo, string.Join(Environment.NewLine, errata), MsgContinue))
|
|
return;
|
|
|
|
Manager.Hover.Stop();
|
|
Editor.Slots.Set(info.Slot, pk);
|
|
Manager.SE.UpdateUndoRedo();
|
|
}
|
|
|
|
private void ClickDelete(object sender, EventArgs e)
|
|
{
|
|
var info = GetSenderInfo(ref sender);
|
|
if ((sender as PictureBox)?.Image == null)
|
|
{ System.Media.SystemSounds.Asterisk.Play(); return; }
|
|
|
|
var sav = info.View.SAV;
|
|
var pk = sav.BlankPKM;
|
|
if (!CheckDest(info, sav, pk))
|
|
return;
|
|
|
|
Manager.Hover.Stop();
|
|
Editor.Slots.Delete(info.Slot);
|
|
Manager.SE.UpdateUndoRedo();
|
|
}
|
|
|
|
private static bool CheckDest(SlotViewInfo<PictureBox> info, SaveFile sav, PKM pk)
|
|
{
|
|
var msg = info.Slot.CanWriteTo(sav, pk);
|
|
if (msg == WriteBlockedMessage.None)
|
|
return true;
|
|
|
|
switch (msg)
|
|
{
|
|
case WriteBlockedMessage.InvalidPartyConfiguration:
|
|
WinFormsUtil.Alert(MsgSaveSlotEmpty);
|
|
break;
|
|
case WriteBlockedMessage.IncompatibleFormat:
|
|
break;
|
|
case WriteBlockedMessage.InvalidDestination:
|
|
WinFormsUtil.Alert(MsgSaveSlotLocked);
|
|
break;
|
|
default:
|
|
throw new ArgumentOutOfRangeException();
|
|
}
|
|
return false;
|
|
}
|
|
|
|
private void ClickShowLegality(object sender, EventArgs e)
|
|
{
|
|
var info = GetSenderInfo(ref sender);
|
|
var sav = info.View.SAV;
|
|
var pk = info.Slot.Read(sav);
|
|
RequestEditorLegality?.Invoke(sender, e, pk);
|
|
}
|
|
|
|
private void MenuOpening(object sender, CancelEventArgs e)
|
|
{
|
|
var items = ((ContextMenuStrip)sender).Items;
|
|
|
|
object ctrl = ((ContextMenuStrip)sender).SourceControl;
|
|
var info = GetSenderInfo(ref ctrl);
|
|
bool SlotFull = (ctrl as PictureBox)?.Image != null;
|
|
bool Editable = info.Slot.CanWriteTo(info.View.SAV);
|
|
bool legality = ModifierKeys == Keys.Control;
|
|
ToggleItem(items, mnuSet, Editable);
|
|
ToggleItem(items, mnuDelete, Editable && SlotFull);
|
|
ToggleItem(items, mnuLegality, legality && SlotFull && RequestEditorLegality != null);
|
|
ToggleItem(items, mnuView, SlotFull || !Editable, true);
|
|
|
|
if (items.Count == 0)
|
|
e.Cancel = true;
|
|
}
|
|
|
|
private static SlotViewInfo<PictureBox> GetSenderInfo(ref object sender)
|
|
{
|
|
var pb = WinFormsUtil.GetUnderlyingControl<PictureBox>(sender);
|
|
var view = WinFormsUtil.FindFirstControlOfType<ISlotViewer<PictureBox>>(pb);
|
|
var loc = view.GetSlotData(pb);
|
|
sender = pb;
|
|
return new SlotViewInfo<PictureBox>(loc, view);
|
|
}
|
|
|
|
private static void ToggleItem(ToolStripItemCollection items, ToolStripItem item, bool visible, bool first = false)
|
|
{
|
|
if (visible)
|
|
{
|
|
if (first)
|
|
items.Insert(0, item);
|
|
else
|
|
items.Add(item);
|
|
}
|
|
else if (items.Contains(item))
|
|
{
|
|
items.Remove(item);
|
|
}
|
|
}
|
|
}
|
|
}
|