mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-22 10:23:09 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
60 lines
No EOL
1.9 KiB
C#
60 lines
No EOL
1.9 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class PokeFinder7 : SaveBlock
|
|
{
|
|
public PokeFinder7(SAV7SM sav, int offset) : base(sav) => Offset = offset;
|
|
public PokeFinder7(SAV7USUM sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
public ushort CameraVersion
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x00));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x00), value);
|
|
}
|
|
|
|
public bool GyroFlag
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x02)) == 1;
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x02), (ushort)(value ? 1 : 0));
|
|
}
|
|
|
|
public uint SnapCount
|
|
{
|
|
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x04));
|
|
set
|
|
{
|
|
if (value > 9999999) // Top bound is unchecked, check anyway
|
|
value = 9999999;
|
|
WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x04), value);
|
|
}
|
|
}
|
|
|
|
public uint ThumbsTotalValue
|
|
{
|
|
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x0C));
|
|
set => WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x0C), value);
|
|
}
|
|
|
|
public uint ThumbsHighValue
|
|
{
|
|
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x10));
|
|
set
|
|
{
|
|
if (value > 9_999_999)
|
|
value = 9_999_999;
|
|
WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x10), value);
|
|
|
|
if (value > ThumbsTotalValue)
|
|
ThumbsTotalValue = value;
|
|
}
|
|
}
|
|
|
|
public ushort TutorialFlags
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x14));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x14), value);
|
|
}
|
|
}
|
|
} |