2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-29 05:43:12 +00:00
PKHeX/PKHeX.Core/Ribbons
Lusamine ab33df2fc9
Enforce weather legality for SWSH ()
* Add weather types by location

Creates a dictionary of possible weather types for each SWSH location.
Unlisted locations may only have Normal weather or do not have any
encounter slots.

* Prune unused weather from static encounters

Some encounters were too permissive with weather, e.g. Sandstorm in
Fields of Honor and Challenge Beach; Snowstorm at Dyna Tree Hill.

A few crossover areas that would have limited the possible weathers were
marked with a "(c)". An example is Nidorina from Giant's Bed crossing
to Frostpoint Field, where Raining and Thunderstorm do not occur.

This additionally organizes encounters by location.

* Move location-weather dictionary to EncounterArea8

* Verify weather marks on encounterslot/static encounters

* Adds some static encounters available through weather bleed

Weathers aren't normally available, but these static encounters are
close enough to the boundary that the weather in an adjacent area can be
used to spawn them.

- Frostpoint Field Snorlax with Raining/Thunderstorm from Giant's Bed
- Snowslide Slope Amaura with Raining/Thunderstorm from Giant's Bed
- Frigid Sea Carracosta with Intense_Sun from Three-Point Pass
- Frigid Sea Magmortar with Intense_Sun from Three-Point Pass
- Ballimere Lake Corviknight with Snowstorm from Giant's Bed
- Ballimere Lake Cryogonal with Snowstorm from Giant's Bed
- Ballimere Lake Tyrunt with all weather from Giant's Bed
- Lakeside Cave Ferrothorn with all weather from Ballimere Lake
- Tunnel to the Top Golbat with all weather from Path to the Peak

* Defer weather marks if incompatible, enforce encounterslot weather

This uses the area weather to check fishing slots and tentatively adds
some tables for weather bleed encounterslots.

* Warm-Up Tunnel gets weather bleed from Training Lowlands

* Update for base PKHeX

* Handle weather bleed for SWSH encounter slots

Co-authored-by: Skadiv <62726360+Skadiv@users.noreply.github.com>

* Minor clean

Having duplicate weather marks is illegal, so just auto-partial match them instead of checking the other marks.

* Rearrange slot weather check logic

* Claim reserved byte in SWSH pkl

* No need for two variable names now

* Valid weather marks on tree/fishing should return with main weather

* Fix tree/fishing deferral and add another surf slot weather bleed

* Disallow tree/fishing encounters from using bleed tables

None are currently known at this time, and only hidden grass encounters
have a weather bleed table

* Condense bleed expression, combine tree/fish flag check

* Move weather-bleed check into EncounterArea8

Makes the dictionaries private instead of internal.

Co-authored-by: Skadiv <62726360+Skadiv@users.noreply.github.com>
2021-07-26 14:28:05 -07:00
..
IRibbonIndex.cs More xmldoc 2021-03-23 21:20:02 -07:00
IRibbonSetCommon3.cs Rename Gen3 Champ ribbon to be more accurate 2021-04-10 12:09:43 -07:00
IRibbonSetCommon4.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
IRibbonSetCommon6.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
IRibbonSetCommon7.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
IRibbonSetCommon8.cs Sword/Shield Update 2019-11-15 17:52:08 -08:00
IRibbonSetEvent3.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
IRibbonSetEvent4.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
IRibbonSetMark8.cs Enforce weather legality for SWSH () 2021-07-26 14:28:05 -07:00
IRibbonSetOnly3.cs Remove artist ribbon restriction requiring master ribbon 2020-09-23 20:47:48 -07:00
IRibbonSetUnique3.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
IRibbonSetUnique4.cs PKHeX.Core Nullable cleanup () 2019-10-16 18:47:31 -07:00
RibbonIndex.cs Enforce weather legality for SWSH () 2021-07-26 14:28:05 -07:00
RibbonInfo.cs Check Winning/Victory ribbons for gen3 origin based on encounter 2020-09-18 16:23:17 -07:00