PKHeX/PKHeX.Core/Legality/Verifiers/IndividualValueVerifier.cs
Kurt 6ee7a8724b
Offload EncounterSlot loading logic to reduce complexity (#2980)
* Rework gen1 slot loading

Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types).

* Revise fuzzy met check for underleveled wild evos

Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison.

Previous commit fixed it for gen1.

* Rework gen2-4 slot loading

Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet...

* Add feebas slots for old/good encounters

* Begin moving properties

Great news! Gen5-7 need to be de-dumbed like Gen1-4.

Then I can remove the bang (!) on the Area accessor and ensure that it's never null!

* Split off XD pokespot slot encounter table type

* Set area in constructor

* Deduplicate g3 roaming encounters

* Deduplicate xd encounter locations (rebattle)

Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format).

* Make all slots have a readonly reference to their parent area

* Minor clean

* Remove "Safari" slot type flag

Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte

Output of slot binaries didn't preserve the Safari flag anyway.

* Update SlotType.cs

* Handle type encounters correctly

* Merge safari area into regular xy area

* Merge dexnav accessor logic

* fix some logic so that tests pass again

rearrange g5 dw init to be done outside of static constructor (initializer instead)
PIDGenerator: friend safari slots now generate with required flawless IV count

* Add cianwood tentacool gift encounter

* Remove unnecessary abstractions

Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain.

Increase restrictiveness of location/type get-set operations

* Minor tweaks, pass parameters

DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can.

* Remove unused legality tables
2020-08-30 10:23:22 -07:00

143 lines
No EOL
4.7 KiB
C#

using System;
using static PKHeX.Core.LegalityCheckStrings;
namespace PKHeX.Core
{
/// <summary>
/// Verifies the <see cref="PKM.IVs"/>.
/// </summary>
public sealed class IndividualValueVerifier : Verifier
{
protected override CheckIdentifier Identifier => CheckIdentifier.IVs;
public override void Verify(LegalityAnalysis data)
{
switch (data.EncounterMatch)
{
case EncounterStatic s:
VerifyIVsStatic(data, s);
break;
case EncounterSlot w:
VerifyIVsSlot(data, w);
break;
case MysteryGift g:
VerifyIVsMystery(data, g);
break;
}
var pkm = data.pkm;
if (pkm.IVTotal == 0)
{
data.AddLine(Get(LFatefulMystery, Severity.Fishy));
}
else
{
var hpiv = pkm.IV_HP;
if (hpiv < 30 && AllIVsEqual(pkm, hpiv))
data.AddLine(Get(LIVAllEqual, Severity.Fishy));
}
}
public static bool AllIVsEqual(PKM pkm) => AllIVsEqual(pkm, pkm.IV_HP);
private static bool AllIVsEqual(PKM pkm, int hpiv)
{
return (pkm.IV_ATK == hpiv) && (pkm.IV_DEF == hpiv) && (pkm.IV_SPA == hpiv) && (pkm.IV_SPD == hpiv) && (pkm.IV_SPE == hpiv);
}
private void VerifyIVsMystery(LegalityAnalysis data, MysteryGift g)
{
var IVs = g.IVs;
if (IVs.Length == 0)
return;
var ivflag = Array.Find(IVs, iv => (byte)(iv - 0xFC) < 3);
if (ivflag == 0) // Random IVs
{
bool valid = Legal.GetIsFixedIVSequenceValidSkipRand(IVs, data.pkm);
if (!valid)
data.AddLine(GetInvalid(LEncGiftIVMismatch));
}
else
{
int IVCount = ivflag - 0xFB; // IV2/IV3
VerifyIVsFlawless(data, IVCount);
}
}
private void VerifyIVsSlot(LegalityAnalysis data, EncounterSlot w)
{
switch (w.Generation)
{
case 6: VerifyIVsGen6(data, w); break;
case 7: VerifyIVsGen7(data); break;
case 8: VerifyIVsGen8(data); break;
}
}
private void VerifyIVsGen8(LegalityAnalysis data)
{
// todo special rules
}
private void VerifyIVsGen7(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.GO)
VerifyIVsGoTransfer(data);
else if (pkm.AbilityNumber == 4)
VerifyIVsFlawless(data, 2); // Chain of 10 yields 5% HA and 2 flawless IVs
}
private void VerifyIVsGen6(LegalityAnalysis data, EncounterSlot w)
{
var pkm = data.pkm;
if (pkm.XY && PersonalTable.XY[data.EncounterMatch.Species].IsEggGroup(15)) // Undiscovered
VerifyIVsFlawless(data, 3);
else if (w.Area.Type == SlotType.FriendSafari)
VerifyIVsFlawless(data, 2);
}
private void VerifyIVsFlawless(LegalityAnalysis data, int count)
{
if (data.pkm.FlawlessIVCount < count)
data.AddLine(GetInvalid(string.Format(LIVF_COUNT0_31, count)));
}
private void VerifyIVsStatic(LegalityAnalysis data, EncounterStatic s)
{
if (s.FlawlessIVCount != 0)
VerifyIVsFlawless(data, s.FlawlessIVCount);
}
private void VerifyIVsGoTransfer(LegalityAnalysis data)
{
var pkm = data.pkm;
if (!IsGoIVSetValid(pkm))
data.AddLine(GetInvalid(LIVNotCorrect));
if (!pkm.IsShiny)
return;
var banlist = Legal.GoTransferSpeciesShinyBan;
// all Shiny Alola Forms are legal, while some of their respective Kanto Forms are not
if (banlist.Contains(pkm.Species) && pkm.AltForm != 1)
data.AddLine(GetInvalid(LEncStaticPIDShiny, CheckIdentifier.PID));
}
private static bool IsGoIVSetValid(PKM pkm)
{
// Stamina*2 | 1 -> HP
// ATK * 2 | 1 -> ATK&SPA
// DEF * 2 | 1 -> DEF&SPD
// Speed is random.
// All IVs must be odd (except speed) and equal to their counterpart.
if ((pkm.GetIV(1) & 1) != 1 || pkm.GetIV(1) != pkm.GetIV(4)) // ATK=SPA
return false;
if ((pkm.GetIV(2) & 1) != 1 || pkm.GetIV(2) != pkm.GetIV(5)) // DEF=SPD
return false;
return (pkm.GetIV(0) & 1) == 1; // HP
}
}
}