mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
69 lines
No EOL
2.1 KiB
C#
69 lines
No EOL
2.1 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class ConfigSave7b : SaveBlock
|
|
{
|
|
/* ===First 8 bits===
|
|
* talkSpeed:2
|
|
* battleAnim:1
|
|
* battleStyle:1
|
|
* language:4
|
|
*
|
|
* everything else: unknown
|
|
*/
|
|
|
|
public ConfigSave7b(SAV7b sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
public int ConfigValue
|
|
{
|
|
get => ReadInt32LittleEndian(Data.AsSpan(Offset));
|
|
set => WriteInt32LittleEndian(Data.AsSpan(Offset), value);
|
|
}
|
|
|
|
public int TalkingSpeed
|
|
{
|
|
get => ConfigValue & 3;
|
|
set => ConfigValue = (ConfigValue & ~3) | (value & 3);
|
|
}
|
|
|
|
public BattleAnimationSetting BattleAnimation
|
|
{
|
|
// Effects OFF = 1, Effects ON = 0
|
|
get => (BattleAnimationSetting)((ConfigValue >> 2) & 1);
|
|
set => ConfigValue = (ConfigValue & ~(1 << 2)) | ((byte)value << 2);
|
|
}
|
|
|
|
public BattleStyleSetting BattleStyle
|
|
{
|
|
// SET = 1, SWITCH = 0
|
|
get => (BattleStyleSetting)((ConfigValue >> 3) & 1);
|
|
set => ConfigValue = (ConfigValue & ~(1 << 3)) | ((byte)value << 3);
|
|
}
|
|
|
|
/// <summary>
|
|
/// <see cref="LanguageID"/> for messages, stored with <see cref="LanguageID.UNUSED_6"/> skipped in the enumeration.
|
|
/// </summary>
|
|
public int Language
|
|
{
|
|
get => GetLanguageID((ConfigValue >> 4) & 0xF);
|
|
set => ConfigValue = ((ConfigValue & ~0xF0) | SetLanguageID(value) << 4);
|
|
}
|
|
|
|
private static int GetLanguageID(int rawValue) => rawValue >= (int) LanguageID.UNUSED_6 ? rawValue + 1 : rawValue; // sets langBank to LanguageID
|
|
private static int SetLanguageID(int rawValue) => rawValue > (int) LanguageID.UNUSED_6 ? rawValue - 1 : rawValue; // sets LanguageID to langBank
|
|
|
|
public enum BattleAnimationSetting
|
|
{
|
|
EffectsON,
|
|
EffectsOFF,
|
|
}
|
|
|
|
public enum BattleStyleSetting
|
|
{
|
|
SWITCH,
|
|
SET,
|
|
}
|
|
}
|
|
} |