mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-22 18:33:14 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
68 lines
No EOL
2.9 KiB
C#
68 lines
No EOL
2.9 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class Mail4 : Mail
|
|
{
|
|
public const int SIZE = 0x38;
|
|
|
|
public Mail4(byte[] data, int ofs) : base(data, ofs) { }
|
|
|
|
public Mail4(byte[] data) : base(data, -1) { }
|
|
|
|
public Mail4(byte? lang, byte? ver) : base(new byte[SIZE])
|
|
{
|
|
if (lang != null) AuthorLanguage = (byte)lang;
|
|
if (ver != null) AuthorVersion = (byte)ver;
|
|
ResetData();
|
|
}
|
|
|
|
public override void CopyTo(SaveFile sav) => sav.SetData(((SAV4)sav).General, Data, DataOffset);
|
|
|
|
private void ResetData()
|
|
{
|
|
AuthorTID = 0;
|
|
AuthorSID = 0;
|
|
AuthorGender = 0;
|
|
MailType = 0xFF;
|
|
AuthorName = string.Empty;
|
|
for (int i = 0; i < 3; i++)
|
|
SetAppearPKM(i, 0xFFFF);
|
|
for (int y = 0; y < 3; y++)
|
|
{
|
|
for (int x = 0; x < 4; x++)
|
|
SetMessage(y, x, x == 1 ? (ushort)0 : (ushort)0xFFFF);
|
|
}
|
|
}
|
|
|
|
public override void CopyTo(PK4 pk4) => pk4.SetHeldMailData(Data);
|
|
public override ushort AuthorTID { get => ReadUInt16LittleEndian(Data.AsSpan(0)); set => WriteUInt16LittleEndian(Data.AsSpan(0), value); }
|
|
public override ushort AuthorSID { get => ReadUInt16LittleEndian(Data.AsSpan(2)); set => WriteUInt16LittleEndian(Data.AsSpan(2), value); }
|
|
public override byte AuthorGender { get => Data[4]; set => Data[4] = value; }
|
|
public override byte AuthorLanguage { get => Data[5]; set => Data[5] = value; }
|
|
public override byte AuthorVersion { get => Data[6]; set => Data[6] = value; }
|
|
public override int MailType { get => Data[7]; set => Data[7] = (byte)value; }
|
|
public override string AuthorName { get => StringConverter4.GetString(Data.AsSpan(8, 0x10)); set => StringConverter4.SetString(Data.AsSpan(8, 0x10), value.AsSpan(), 7, StringConverterOption.ClearFF); }
|
|
public int GetAppearPKM(int index) => ReadUInt16LittleEndian(Data.AsSpan(0x1C - (index * 2)));
|
|
public void SetAppearPKM(int index, int value) => WriteUInt16LittleEndian(Data.AsSpan(0x1C - (index * 2)), (ushort)(value == 0 ? 0xFFFF : value));
|
|
public override ushort GetMessage(int index1, int index2) => ReadUInt16LittleEndian(Data.AsSpan(0x20 + (((index1 * 4) + index2) * 2)));
|
|
public override void SetMessage(int index1, int index2, ushort value) => WriteUInt16LittleEndian(Data.AsSpan(0x20 + (((index1 * 4) + index2) * 2)), value);
|
|
|
|
public override bool? IsEmpty => MailType switch
|
|
{
|
|
0xFF => true,
|
|
<= 11 => false,
|
|
_ => null,
|
|
};
|
|
|
|
public override void SetBlank() => SetBlank(0, 0);
|
|
|
|
public void SetBlank(byte lang, byte ver)
|
|
{
|
|
Array.Clear(Data, 0, Data.Length);
|
|
AuthorLanguage = lang;
|
|
AuthorVersion = ver;
|
|
}
|
|
}
|
|
} |