mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-22 18:33:14 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
33 lines
841 B
C#
33 lines
841 B
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public abstract class Gen3MysteryData
|
|
{
|
|
public readonly byte[] Data;
|
|
|
|
protected Gen3MysteryData(byte[] data) => Data = data;
|
|
|
|
public uint Checksum
|
|
{
|
|
get => ReadUInt32LittleEndian(Data.AsSpan(0));
|
|
set => WriteUInt32LittleEndian(Data.AsSpan(0), value);
|
|
}
|
|
|
|
public bool IsChecksumValid() => Checksum == GetChecksum(Data);
|
|
public void FixChecksum() => Checksum = GetChecksum(Data);
|
|
|
|
private static uint GetChecksum(ReadOnlySpan<byte> data)
|
|
{
|
|
uint sum = 0;
|
|
for (var i = 4; i < data.Length; i++)
|
|
{
|
|
var b = data[i];
|
|
sum += b;
|
|
}
|
|
|
|
return sum;
|
|
}
|
|
}
|
|
}
|