PKHeX/PKHeX.Core/Legality/MoveListSuggest.cs
Kurt 9166d0eb64
Refactoring: Move Source (Legality) (#3560)
Rewrites a good amount of legality APIs pertaining to:
* Legal moves that can be learned
* Evolution chains & cross-generation paths
* Memory validation with forgotten moves

In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data.

The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space.

The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation.

* `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game.
* `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`).
* Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
2022-08-03 16:15:27 -07:00

167 lines
6.4 KiB
C#

using System;
using System.Buffers;
using System.Collections.Generic;
using System.Linq;
namespace PKHeX.Core;
public static class MoveListSuggest
{
private static int[] GetSuggestedMoves(PKM pk, EvolutionHistory evoChains, MoveSourceType types, IEncounterTemplate enc)
{
if (pk.IsEgg && pk.Format <= 5) // pre relearn
return MoveList.GetBaseEggMoves(pk, pk.Species, 0, (GameVersion)pk.Version, pk.CurrentLevel);
if (types != MoveSourceType.None)
return GetValidMoves(pk, enc, evoChains, types).ToArray();
// try to give current moves
if (enc.Generation <= 2)
{
var lvl = pk.Format >= 7 ? pk.Met_Level : pk.CurrentLevel;
var ver = enc.Version;
return MoveLevelUp.GetEncounterMoves(enc.Species, 0, lvl, ver);
}
if (pk.Species == enc.Species)
{
return MoveLevelUp.GetEncounterMoves(pk.Species, pk.Form, pk.CurrentLevel, (GameVersion)pk.Version);
}
return GetValidMoves(pk, enc, evoChains, types).ToArray();
}
private static IEnumerable<int> GetValidMoves(PKM pk, IEncounterTemplate enc, EvolutionHistory evoChains, MoveSourceType types = MoveSourceType.ExternalSources)
{
var length = pk.MaxMoveID + 1;
bool[] rent = ArrayPool<bool>.Shared.Rent(length);
LearnPossible.Get(pk, enc, evoChains, rent, types);
for (int i = 1; i < length; i++)
{
if (rent[i])
yield return i;
}
ArrayPool<bool>.Shared.Return(rent, true);
}
/// <summary>
/// Gets four moves which can be learned depending on the input arguments.
/// </summary>
/// <param name="analysis">Parse information to generate a moveset for.</param>
/// <param name="types">Allowed move sources for populating the result array</param>
public static int[] GetSuggestedCurrentMoves(this LegalityAnalysis analysis, MoveSourceType types = MoveSourceType.All)
{
if (!analysis.Parsed)
return new int[4];
var pk = analysis.Entity;
if (pk.IsEgg && pk.Format >= 6)
return pk.RelearnMoves;
if (pk.IsEgg)
types = types.ClearNonEggSources();
var info = analysis.Info;
return GetSuggestedMoves(pk, info.EvoChainsAllGens, types, info.EncounterOriginal);
}
/// <summary>
/// Gets the current <see cref="PKM.RelearnMoves"/> array of four moves that might be legal.
/// </summary>
/// <remarks>Use <see cref="GetSuggestedRelearnMovesFromEncounter"/> instead of calling directly; this method just puts default values in without considering the final moveset.</remarks>
public static IReadOnlyList<int> GetSuggestedRelearn(this IEncounterTemplate enc, PKM pk)
{
if (LearnVerifierRelearn.ShouldNotHaveRelearnMoves(enc, pk))
return Empty;
return GetSuggestedRelearnInternal(enc, pk);
}
// Invalid encounters won't be recognized as an EncounterEgg; check if it *should* be a bred egg.
private static IReadOnlyList<int> GetSuggestedRelearnInternal(this IEncounterTemplate enc, PKM pk) => enc switch
{
IRelearn { Relearn: int[] { Length: not 0 } r } => r,
EncounterEgg or EncounterInvalid {EggEncounter: true} => GetSuggestedRelearnEgg(enc, pk),
_ => Empty,
};
private static int[] GetSuggestedRelearnEgg(IEncounterTemplate enc, PKM pk)
{
Span<int> current = stackalloc int[4];
pk.GetRelearnMoves(current);
Span<int> expected = stackalloc int[current.Length];
_ = MoveBreed.GetExpectedMoves(current, enc, expected);
return expected.ToArray();
}
private static readonly IReadOnlyList<int> Empty = new int[4];
/// <summary>
/// Gets the current <see cref="PKM.RelearnMoves"/> array of four moves that might be legal.
/// </summary>
public static IReadOnlyList<int> GetSuggestedRelearnMovesFromEncounter(this LegalityAnalysis analysis, IEncounterTemplate? enc = null)
{
var info = analysis.Info;
enc ??= info.EncounterOriginal;
var pk = analysis.Entity;
if (LearnVerifierRelearn.ShouldNotHaveRelearnMoves(enc, pk))
return Empty;
if (enc is EncounterEgg or EncounterInvalid {EggEncounter: true})
return enc.GetSuggestedRelearnEgg(info.Moves, pk);
return enc.GetSuggestedRelearnInternal(pk);
}
private static IReadOnlyList<int> GetSuggestedRelearnEgg(this IEncounterTemplate enc, ReadOnlySpan<MoveResult> parse, PKM pk)
{
var result = enc.GetEggRelearnMoves(parse, pk);
int generation = enc.Generation;
if (generation <= 5) // gen2 does not have splitbreed, <=5 do not have relearn moves and shouldn't even be here.
return result;
// Split-breed species like Budew & Roselia may be legal for one, and not the other.
// If we're not a split-breed or are already legal, return.
var split = Breeding.GetSplitBreedGeneration(generation);
if (!split.Contains(enc.Species))
return result;
var tmp = pk.Clone();
tmp.SetRelearnMoves(result);
var la = new LegalityAnalysis(tmp);
var moves = la.Info.Moves;
if (MoveResult.AllValid(moves))
return result;
// Try again with the other split-breed species if possible.
var incense = EncounterEggGenerator.GenerateEggs(tmp, generation).FirstOrDefault();
if (incense is null || incense.Species == enc.Species)
return result;
return incense.GetEggRelearnMoves(parse, pk);
}
private static int[] GetEggRelearnMoves(this IEncounterTemplate enc, ReadOnlySpan<MoveResult> parse, PKM pk)
{
// Extract a list of the moves that should end up in the relearn move list.
Span<int> moves = stackalloc int[parse.Length];
LoadRelearnFlagged(moves, parse, pk);
Span<int> expected = stackalloc int[moves.Length];
_ = MoveBreed.GetExpectedMoves(moves, enc, expected);
return expected.ToArray();
}
private static void LoadRelearnFlagged(Span<int> moves, ReadOnlySpan<MoveResult> parse, PKM pk)
{
// Loads only indexes that are flagged as relearn moves
int count = 0;
for (int index = 0; index < parse.Length; index++)
{
var move = parse[index];
if (move.ShouldBeInRelearnMoves())
moves[count++] = pk.GetMove(index);
}
}
}