mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-21 09:53:14 +00:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
66 lines
2.4 KiB
C#
66 lines
2.4 KiB
C#
using System;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Group that checks the source of a move in <see cref="GameVersion.Gen7b"/>.
|
|
/// </summary>
|
|
public sealed class LearnGroup7b : ILearnGroup
|
|
{
|
|
public static readonly LearnGroup7b Instance = new();
|
|
private const int Generation = 7;
|
|
|
|
public ILearnGroup? GetPrevious(PKM pk, EvolutionHistory history, IEncounterTemplate enc, LearnOption option) => null;
|
|
public bool HasVisited(PKM pk, EvolutionHistory history) => history.Gen7b.Length != 0;
|
|
|
|
public bool Check(Span<MoveResult> result, ReadOnlySpan<int> current, PKM pk, EvolutionHistory history,
|
|
IEncounterTemplate enc, MoveSourceType types = MoveSourceType.All, LearnOption option = LearnOption.Current)
|
|
{
|
|
var evos = history.Gen7b;
|
|
for (var i = 0; i < evos.Length; i++)
|
|
Check(result, current, pk, evos[i], i);
|
|
|
|
return MoveResult.AllParsed(result);
|
|
}
|
|
|
|
private static void Check(Span<MoveResult> result, ReadOnlySpan<int> current, PKM pk, EvoCriteria evo, int stage)
|
|
{
|
|
var game = LearnSource7GG.Instance;
|
|
if (!game.TryGetPersonal(evo.Species, evo.Form, out var pi))
|
|
return; // should never happen.
|
|
|
|
for (int i = result.Length - 1; i >= 0; i--)
|
|
{
|
|
if (result[i].Valid)
|
|
continue;
|
|
|
|
var move = current[i];
|
|
var chk = game.GetCanLearn(pk, pi, evo, move);
|
|
if (chk != default)
|
|
result[i] = new(chk, (byte)stage, Generation);
|
|
}
|
|
}
|
|
|
|
public void GetAllMoves(Span<bool> result, PKM pk, EvolutionHistory history, IEncounterTemplate enc, MoveSourceType types = MoveSourceType.All, LearnOption option = LearnOption.Current)
|
|
{
|
|
if (types.HasFlagFast(MoveSourceType.Encounter) && enc.Generation == Generation)
|
|
FlagEncounterMoves(enc, result);
|
|
|
|
foreach (var evo in history.Gen7b)
|
|
LearnSource7GG.Instance.GetAllMoves(result, pk, evo, types);
|
|
}
|
|
|
|
private static void FlagEncounterMoves(IEncounterTemplate enc, Span<bool> result)
|
|
{
|
|
if (enc is IMoveset { Moves: int[] { Length: not 0 } x })
|
|
{
|
|
foreach (var move in x)
|
|
result[move] = true;
|
|
}
|
|
if (enc is IRelearn { Relearn: int[] { Length: not 0 } r })
|
|
{
|
|
foreach (var move in r)
|
|
result[move] = true;
|
|
}
|
|
}
|
|
}
|