mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-25 03:43:16 +00:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
34 lines
1,013 B
C#
34 lines
1,013 B
C#
using System;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Links a <see cref="EvolutionMethod"/> to the source <see cref="Species"/> and <see cref="Form"/> that the method can be triggered from.
|
|
/// </summary>
|
|
public struct EvolutionLink
|
|
{
|
|
private Func<PKM, bool>? IsBanned = null;
|
|
public readonly EvolutionMethod Method;
|
|
public readonly ushort Species;
|
|
public readonly byte Form;
|
|
|
|
public EvolutionLink(ushort species, byte form, EvolutionMethod method)
|
|
{
|
|
Species = species;
|
|
Form = form;
|
|
Method = method;
|
|
}
|
|
|
|
public bool IsEmpty => Species == 0;
|
|
|
|
public (ushort Species, byte Form) Tuple => (Species, Form);
|
|
|
|
public void Ban(Func<PKM, bool> check) => IsBanned = check;
|
|
|
|
/// <summary>
|
|
/// Checks if the <see cref="Method"/> is allowed.
|
|
/// </summary>
|
|
/// <param name="pk">Entity to check</param>
|
|
/// <returns>True if banned, false if allowed.</returns>
|
|
public bool IsEvolutionBanned(PKM pk) => IsBanned != null && IsBanned(pk);
|
|
}
|