mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-30 07:50:32 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
84 lines
2.8 KiB
C#
84 lines
2.8 KiB
C#
using System;
|
||
using FluentAssertions;
|
||
using PKHeX.Core;
|
||
using Xunit;
|
||
|
||
namespace PKHeX.Tests.PKM
|
||
{
|
||
public class StringTests
|
||
{
|
||
[Fact]
|
||
public void Gen7ZHLengthCorrect()
|
||
{
|
||
StringConverter7ZH.Gen7_ZHRaw.Length.Should().Be(StringConverter7ZH.Gen7_ZHLength);
|
||
}
|
||
|
||
[Fact]
|
||
public void EncodesOTNameCorrectly()
|
||
{
|
||
const string name_fabian = "Fabian♂";
|
||
var pkm = new PK7 { OT_Name = name_fabian };
|
||
Span<byte> byte_fabian = stackalloc byte[]
|
||
{
|
||
0x46, 0x00, // F
|
||
0x61, 0x00, // a
|
||
0x62, 0x00, // b
|
||
0x69, 0x00, // i
|
||
0x61, 0x00, // a
|
||
0x6E, 0x00, // n
|
||
0x8E, 0xE0, // ♂
|
||
0x00, 0x00, // \0 terminator
|
||
};
|
||
CheckStringGetSet(nameof(pkm.OT_Name), name_fabian, pkm.OT_Name, byte_fabian, pkm.OT_Trash);
|
||
}
|
||
|
||
[Fact]
|
||
public void EncodesNicknameCorrectly()
|
||
{
|
||
const string name_nidoran = "ニドラン♀";
|
||
var pkm = new PK7 { Nickname = name_nidoran };
|
||
Span<byte> byte_nidoran = stackalloc byte[]
|
||
{
|
||
0xCB, 0x30, // ニ
|
||
0xC9, 0x30, // ド
|
||
0xE9, 0x30, // ラ
|
||
0xF3, 0x30, // ン
|
||
0x40, 0x26, // ♀
|
||
0x00, 0x00, // \0 terminator
|
||
};
|
||
CheckStringGetSet(nameof(pkm.Nickname), name_nidoran, pkm.Nickname, byte_nidoran, pkm.Nickname_Trash);
|
||
}
|
||
|
||
private static void CheckStringGetSet(string check, string instr, string outstr, ReadOnlySpan<byte> indata, ReadOnlySpan<byte> outdata)
|
||
{
|
||
instr.Should().BeEquivalentTo(outstr);
|
||
|
||
outdata = outdata[..indata.Length];
|
||
|
||
indata.SequenceEqual(outdata).Should()
|
||
.BeTrue($"expected {check} to set properly, instead got {Hex(outdata)}");
|
||
}
|
||
|
||
private static string Hex(ReadOnlySpan<byte> outdata)
|
||
{
|
||
var sb = new System.Text.StringBuilder(outdata.Length);
|
||
foreach (var b in outdata)
|
||
sb.AppendFormat("{0:X2}, ", b);
|
||
return sb.ToString();
|
||
}
|
||
|
||
[Theory]
|
||
[InlineData(0x0F5, 0xFF5E)] // ～
|
||
[InlineData(0x0FA, 0x2660)] // ♠
|
||
[InlineData(0x0FB, 0x2663)] // ♣
|
||
[InlineData(0x0FC, 0x2665)] // ♥
|
||
[InlineData(0x0FD, 0x2666)] // ♦
|
||
[InlineData(0x0FE, 0x2605)] // ★
|
||
[InlineData(0x105, 0x266A)] // ♪
|
||
public static void Encode45(ushort g4, char g5)
|
||
{
|
||
StringConverter4Util.ConvertChar2ValueG4(g5).Should().Be(g4);
|
||
StringConverter4Util.ConvertValue2CharG4(g4).Should().Be(g5);
|
||
}
|
||
}
|
||
}
|