PKHeX/Tests/PKHeX.Core.Tests/Legality/Illegal
Kurt 416f5fe183 Check Winning/Victory ribbons for gen3 origin based on encounter
Closes #2990 ty @Atrius97 !

Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly.

Rewrite the national ribbon check for clarity
Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon.

Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 16:23:17 -07:00
..
AltForm Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
Evolution Provide min level to evochain fetch 2019-07-02 08:34:28 -07:00
Misc Flag non-Poké Ball XD teddiursa 2020-09-13 14:43:48 -07:00
Moves Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
Ribbons Check Winning/Victory ribbons for gen3 origin based on encounter 2020-09-18 16:23:17 -07:00
WC3 Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00
WC7 Refine zygarde encounter form checking logic 2020-09-13 15:45:15 -07:00
Wild Port tests to .Net Core (#2156) 2018-11-06 15:25:35 -08:00