mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 06:20:25 +00:00
768047cd80
* Rewrite ribbon verification * Explicitly verifies all ribbons instead of chained iterators. * Verifies using only the stack, using `struct` and `Span<T>`. No allocation on heap, or `IEnumerable` iterators. * Verifies all egg ribbons using a separate method, explicitly implemented. No reflection overhead. * Separates each ribbon interface to separate `static` classes. Easier to identify code needing change on new game update. * Extracted logic for specific ribbons. Can easily revise complicated ribbon's acquisition rules. * Simplifies GiveAll/RemoveAll legal ribbon mutations. No reflection overhead, and no allocation. * Can be expanded in the future if we need to track conditions for ribbon acquisition (was Sinnoh Champ received in BDSP or Gen4?) End result is a more performant implementation and easier to maintain & reuse logic.
31 lines
1.1 KiB
C#
31 lines
1.1 KiB
C#
namespace PKHeX.Core;
|
|
|
|
/// <summary> Ribbons introduced in Generation 4 for Special Events </summary>
|
|
public interface IRibbonSetEvent4
|
|
{
|
|
bool RibbonClassic { get; set; }
|
|
bool RibbonWishing { get; set; }
|
|
bool RibbonPremier { get; set; }
|
|
bool RibbonEvent { get; set; }
|
|
bool RibbonBirthday { get; set; }
|
|
bool RibbonSpecial { get; set; }
|
|
bool RibbonWorld { get; set; }
|
|
bool RibbonChampionWorld { get; set; }
|
|
bool RibbonSouvenir { get; set; }
|
|
}
|
|
|
|
internal static partial class RibbonExtensions
|
|
{
|
|
internal static void CopyRibbonSetEvent4(this IRibbonSetEvent4 set, IRibbonSetEvent4 dest)
|
|
{
|
|
dest.RibbonClassic = set.RibbonClassic;
|
|
dest.RibbonWishing = set.RibbonWishing;
|
|
dest.RibbonPremier = set.RibbonPremier;
|
|
dest.RibbonEvent = set.RibbonEvent;
|
|
dest.RibbonBirthday = set.RibbonBirthday;
|
|
dest.RibbonSpecial = set.RibbonSpecial;
|
|
dest.RibbonWorld = set.RibbonWorld;
|
|
dest.RibbonChampionWorld = set.RibbonChampionWorld;
|
|
dest.RibbonSouvenir = set.RibbonSouvenir;
|
|
}
|
|
}
|