mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-23 20:43:07 +00:00
88830e0d00
Updates from net46->net7, dropping support for mono in favor of using the latest runtime (along with the performance/API improvements). Releases will be posted as 64bit only for now. Refactors a good amount of internal API methods to be more performant and more customizable for future updates & fixes. Adds functionality for Batch Editor commands to `>`, `<` and <=/>= TID/SID properties renamed to TID16/SID16 for clarity; other properties exposed for Gen7 / display variants. Main window has a new layout to account for DPI scaling (8 point grid) Fixed: Tatsugiri and Paldean Tauros now output Showdown form names as Showdown expects Changed: Gen9 species now interact based on the confirmed National Dex IDs (closes #3724) Fixed: Pokedex set all no longer clears species with unavailable non-base forms (closes #3720) Changed: Hyper Training suggestions now apply for level 50 in SV. (closes #3714) Fixed: B2/W2 hatched egg met locations exclusive to specific versions are now explicitly checked (closes #3691) Added: Properties for ribbon/mark count (closes #3659) Fixed: Traded SV eggs are now checked correctly (closes #3692)
63 lines
1.7 KiB
C#
63 lines
1.7 KiB
C#
using static PKHeX.Core.LegalityCheckStrings;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Verifies the <see cref="PKM.OT_Name"/>.
|
|
/// </summary>
|
|
public sealed class TrainerIDVerifier : Verifier
|
|
{
|
|
protected override CheckIdentifier Identifier => CheckIdentifier.Trainer;
|
|
|
|
public override void Verify(LegalityAnalysis data)
|
|
{
|
|
var pk = data.Entity;
|
|
if (!TrainerNameVerifier.IsPlayerOriginalTrainer(data.EncounterMatch))
|
|
return; // already verified
|
|
|
|
if (pk.BDSP)
|
|
{
|
|
// Game loops to ensure a nonzero full-ID
|
|
// int.MaxValue cannot be yielded by Unity's Random.Range[min, max)
|
|
var id32 = pk.ID32;
|
|
if (id32 is 0 or int.MaxValue)
|
|
{
|
|
data.AddLine(GetInvalid(LOT_IDInvalid));
|
|
return;
|
|
}
|
|
}
|
|
else if (pk.VC && pk.SID16 != 0)
|
|
{
|
|
data.AddLine(GetInvalid(LOT_SID0Invalid));
|
|
return;
|
|
}
|
|
|
|
if (pk is { ID32: 0 })
|
|
{
|
|
data.AddLine(Get(LOT_IDs0, Severity.Fishy));
|
|
}
|
|
else if (pk.TID16 == pk.SID16)
|
|
{
|
|
data.AddLine(Get(LOT_IDEqual, Severity.Fishy));
|
|
}
|
|
else if (pk.TID16 == 0)
|
|
{
|
|
data.AddLine(Get(LOT_TID0, Severity.Fishy));
|
|
}
|
|
else if (pk.SID16 == 0)
|
|
{
|
|
data.AddLine(Get(LOT_SID0, Severity.Fishy));
|
|
}
|
|
else if (IsOTIDSuspicious(pk.TID16, pk.SID16))
|
|
{
|
|
data.AddLine(Get(LOTSuspicious, Severity.Fishy));
|
|
}
|
|
}
|
|
|
|
public static bool IsOTIDSuspicious(ushort tid16, ushort sid16) => (tid16, sid16) switch
|
|
{
|
|
(12345, 54321) => true,
|
|
(15040, 18831) => true, // 1234_123456 (SID7_TID7)
|
|
_ => false,
|
|
};
|
|
}
|