mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-17 16:03:10 +00:00
02420d3e93
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
76 lines
3.1 KiB
C#
76 lines
3.1 KiB
C#
namespace PKHeX.Core
|
|
{
|
|
/// <summary> Common Ribbons introduced in Generation 6 </summary>
|
|
public interface IRibbonSetCommon6
|
|
{
|
|
bool RibbonChampionKalos { get; set; }
|
|
bool RibbonChampionG6Hoenn { get; set; }
|
|
bool RibbonBestFriends { get; set; }
|
|
bool RibbonTraining { get; set; }
|
|
bool RibbonBattlerSkillful { get; set; }
|
|
bool RibbonBattlerExpert { get; set; }
|
|
|
|
bool RibbonContestStar { get; set; }
|
|
bool RibbonMasterCoolness { get; set; }
|
|
bool RibbonMasterBeauty { get; set; }
|
|
bool RibbonMasterCuteness { get; set; }
|
|
bool RibbonMasterCleverness { get; set; }
|
|
bool RibbonMasterToughness { get; set; }
|
|
|
|
int RibbonCountMemoryContest { get; set; }
|
|
int RibbonCountMemoryBattle { get; set; }
|
|
}
|
|
|
|
internal static partial class RibbonExtensions
|
|
{
|
|
private static readonly string[] RibbonSetNamesCommon6Bool =
|
|
{
|
|
nameof(IRibbonSetCommon6.RibbonChampionKalos), nameof(IRibbonSetCommon6.RibbonChampionG6Hoenn), // nameof(IRibbonSetCommon6.RibbonBestFriends),
|
|
nameof(IRibbonSetCommon6.RibbonTraining), nameof(IRibbonSetCommon6.RibbonBattlerSkillful), nameof(IRibbonSetCommon6.RibbonBattlerExpert),
|
|
nameof(IRibbonSetCommon6.RibbonContestStar), nameof(IRibbonSetCommon6.RibbonMasterCoolness), nameof(IRibbonSetCommon6.RibbonMasterBeauty),
|
|
nameof(IRibbonSetCommon6.RibbonMasterCuteness), nameof(IRibbonSetCommon6.RibbonMasterCleverness), nameof(IRibbonSetCommon6.RibbonMasterToughness),
|
|
};
|
|
|
|
private static readonly string[] RibbonSetNamesCommon6Contest =
|
|
{
|
|
nameof(IRibbonSetCommon6.RibbonMasterCoolness), nameof(IRibbonSetCommon6.RibbonMasterBeauty),
|
|
nameof(IRibbonSetCommon6.RibbonMasterCuteness), nameof(IRibbonSetCommon6.RibbonMasterCleverness),
|
|
nameof(IRibbonSetCommon6.RibbonMasterToughness),
|
|
};
|
|
|
|
internal static bool[] RibbonBits(this IRibbonSetCommon6 set)
|
|
{
|
|
return new[]
|
|
{
|
|
set.RibbonChampionKalos,
|
|
set.RibbonChampionG6Hoenn,
|
|
//set.RibbonBestFriends,
|
|
set.RibbonTraining,
|
|
set.RibbonBattlerSkillful,
|
|
set.RibbonBattlerExpert,
|
|
|
|
set.RibbonContestStar,
|
|
set.RibbonMasterCoolness,
|
|
set.RibbonMasterBeauty,
|
|
set.RibbonMasterCuteness,
|
|
set.RibbonMasterCleverness,
|
|
set.RibbonMasterToughness,
|
|
};
|
|
}
|
|
|
|
internal static bool[] RibbonBitsContest(this IRibbonSetCommon6 set)
|
|
{
|
|
return new[]
|
|
{
|
|
set.RibbonMasterCoolness,
|
|
set.RibbonMasterBeauty,
|
|
set.RibbonMasterCuteness,
|
|
set.RibbonMasterCleverness,
|
|
set.RibbonMasterToughness,
|
|
};
|
|
}
|
|
|
|
internal static string[] RibbonNamesBool(this IRibbonSetCommon6 _) => RibbonSetNamesCommon6Bool;
|
|
internal static string[] RibbonNamesContest(this IRibbonSetCommon6 _) => RibbonSetNamesCommon6Contest;
|
|
}
|
|
}
|