mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
41 lines
1.2 KiB
C#
41 lines
1.2 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Gen5 Block Info
|
|
/// </summary>
|
|
public sealed class BlockInfoNDS : BlockInfo
|
|
{
|
|
private readonly int ChecksumOffset;
|
|
private readonly int ChecksumMirror;
|
|
|
|
public BlockInfoNDS(int offset, int length, int chkOffset, int chkMirror)
|
|
{
|
|
Offset = offset;
|
|
Length = length;
|
|
ChecksumOffset = chkOffset;
|
|
ChecksumMirror = chkMirror;
|
|
}
|
|
|
|
private ushort GetChecksum(Span<byte> data) => Checksums.CRC16_CCITT(data.Slice(Offset, Length));
|
|
|
|
protected override bool ChecksumValid(Span<byte> data)
|
|
{
|
|
ushort chk = GetChecksum(data);
|
|
if (chk != ReadUInt16LittleEndian(data[ChecksumOffset..]))
|
|
return false;
|
|
if (chk != ReadUInt16LittleEndian(data[ChecksumMirror..]))
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
protected override void SetChecksum(Span<byte> data)
|
|
{
|
|
ushort chk = GetChecksum(data);
|
|
WriteUInt16LittleEndian(data[ChecksumOffset..], chk);
|
|
WriteUInt16LittleEndian(data[ChecksumMirror..], chk);
|
|
}
|
|
}
|
|
}
|