mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-23 12:33:06 +00:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
26 lines
1.1 KiB
C#
26 lines
1.1 KiB
C#
using System.Collections.Generic;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Generation 4 <see cref="SaveFile"/> object that reads Generation 4 PokeStock .stk dumps.
|
|
/// </summary>
|
|
public sealed class Bank4 : BulkStorage
|
|
{
|
|
public Bank4(byte[] data) : base(data, typeof(PK4), 0) => Version = GameVersion.HGSS;
|
|
|
|
public override IPersonalTable Personal => PersonalTable.HGSS;
|
|
public override IReadOnlyList<ushort> HeldItems => Legal.HeldItems_HGSS;
|
|
protected override SaveFile CloneInternal() => new Bank4((byte[])Data.Clone());
|
|
public override string PlayTimeString => Checksums.CRC16Invert(Data).ToString("X4");
|
|
protected internal override string ShortSummary => PlayTimeString;
|
|
public override string Extension => ".stk";
|
|
|
|
public override int BoxCount => 64;
|
|
private const int BoxNameSize = 0x18;
|
|
|
|
private int BoxDataSize => SlotsPerBox * SIZE_STORED;
|
|
public override int GetBoxOffset(int box) => Box + (BoxDataSize * box);
|
|
public override string GetBoxName(int box) => GetString(GetBoxNameOffset(box), BoxNameSize / 2);
|
|
private static int GetBoxNameOffset(int box) => 0x3FC00 + (0x19 * box);
|
|
}
|