mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
50 lines
1.8 KiB
C#
50 lines
1.8 KiB
C#
#if !NET6
|
|
#pragma warning disable
|
|
// ReSharper disable once UnusedType.Global
|
|
global using static PKHeX.Core.Buffers.Binary.Extra.BinaryPrimitives;
|
|
using System;
|
|
using System.Runtime.InteropServices;
|
|
|
|
namespace PKHeX.Core.Buffers.Binary.Extra
|
|
{
|
|
internal static class BinaryPrimitives
|
|
{
|
|
public static float ReadSingleLittleEndian(ReadOnlySpan<byte> data) => MemoryMarshal.Read<float>(data);
|
|
public static void WriteSingleLittleEndian(Span<byte> data, float value) => MemoryMarshal.Write(data, ref value);
|
|
public static double ReadDoubleLittleEndian(ReadOnlySpan<byte> data) => MemoryMarshal.Read<double>(data);
|
|
public static void WriteDoubleLittleEndian(Span<byte> data, double value) => MemoryMarshal.Write(data, ref value);
|
|
}
|
|
}
|
|
|
|
namespace System.Runtime.CompilerServices
|
|
{
|
|
using Diagnostics;
|
|
using Diagnostics.CodeAnalysis;
|
|
|
|
/// <summary>
|
|
/// Reserved to be used by the compiler for tracking metadata.
|
|
/// This class should not be used by developers in source code.
|
|
/// </summary>
|
|
[ExcludeFromCodeCoverage, DebuggerNonUserCode]
|
|
internal static class IsExternalInit
|
|
{
|
|
}
|
|
}
|
|
|
|
namespace System.Diagnostics.CodeAnalysis
|
|
{
|
|
[AttributeUsage(AttributeTargets.Parameter)]
|
|
internal sealed class NotNullWhenAttribute : Attribute
|
|
{
|
|
/// <summary>Initializes the attribute with the specified return value condition.</summary>
|
|
/// <param name="returnValue">
|
|
/// The return value condition. If the method returns this value, the associated parameter will not be null.
|
|
/// </param>
|
|
public NotNullWhenAttribute(bool returnValue) => ReturnValue = returnValue;
|
|
|
|
/// <summary>Gets the return value condition.</summary>
|
|
public bool ReturnValue { get; }
|
|
}
|
|
}
|
|
#pragma warning restore
|
|
#endif
|