mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-19 08:53:28 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
47 lines
1.4 KiB
C#
47 lines
1.4 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Generation 1 Evolution Branch Entries
|
|
/// </summary>
|
|
public static class EvolutionSet1
|
|
{
|
|
private static EvolutionMethod GetMethod(ReadOnlySpan<byte> data)
|
|
{
|
|
int method = data[0];
|
|
int species = data[1];
|
|
int arg = data[2];
|
|
|
|
return (method == 1)
|
|
? new EvolutionMethod(method, species, level: arg)
|
|
: new EvolutionMethod(method, species, argument: arg);
|
|
}
|
|
|
|
public static IReadOnlyList<EvolutionMethod[]> GetArray(ReadOnlySpan<byte> data, int maxSpecies)
|
|
{
|
|
var evos = new EvolutionMethod[maxSpecies + 1][];
|
|
int ofs = 0;
|
|
const int bpe = 3;
|
|
for (int i = 0; i < evos.Length; i++)
|
|
{
|
|
int count = data[ofs];
|
|
ofs++;
|
|
if (count == 0)
|
|
{
|
|
evos[i] = Array.Empty<EvolutionMethod>();
|
|
continue;
|
|
}
|
|
var m = new EvolutionMethod[count];
|
|
for (int j = 0; j < m.Length; j++)
|
|
{
|
|
m[j] = GetMethod(data.Slice(ofs, bpe));
|
|
ofs += bpe;
|
|
}
|
|
evos[i] = m;
|
|
}
|
|
return evos;
|
|
}
|
|
}
|
|
}
|