PKHeX/PKHeX.Core/Legality/Moves
Kurt 0626b0c29b
Add Breeding move ordering logic, and use in legality analysis (#3183)
* Initial bred moveset validation logic

Unpeel the inheritance via recursion and permitted moves

* Volt tackle considerations

* Optimize out empty slot skips

* Add tests, fix off-by-one's

* Require all base moves if empty slot in moveset

* Add test to prove failure per Anubis' provided test

* Tweak enum labels for easier debugging

When two enums share the same underlying value, the ToString/name of the value may be either of the two (or the last defined one, in my debugging). Just give it a separate magic value.

* Fix recursion oopsie

Also check for scenario where no-base-moves but not enough moves to push base moves out

* Add Crystal tutor checks

* Add specialized gen2 verification method

Game loops through father's moves and pushes in one iteration, rather than checking by type.

* Add another case with returning base move

* Add push-out requirement for re-added base moves

* Minor tweaks

Condense tests, fix another off-by-one noticed when creating tests

* Disallow inherited parent levelup moves

Disallow volt tackle on Gen2/R/S

* Split MoveBreed into generation specific classes

Gen2 behaves slightly different from Gen3/4, which behaves slightly different from Gen5... and Gen6 behaves differently too.

Add some xmldoc as the api is starting to solidify

* Add method overload that returns the parse

Verify that the parse order is as expected

* Add reordering suggestion logic

Try sorting first, then go nuclear with rebuilding.

* Return base moves if complete fail

* Set base moves when generating eggs, only.

* Use breed logic to check for egg ordering legality

Don't bother helping for split-breed species
2021-04-04 18:30:01 -07:00
..
Breeding Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
EggInfoSource.cs Minor annotation tweaks 2021-01-12 22:26:08 -08:00
GameData.cs Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
LearnInfo.cs Target type'd new 2020-12-21 17:17:56 -08:00
LearnLookup.cs Unify concepts with different names 2020-12-10 20:42:30 -08:00
MoveEgg.cs Simplify shared egg move array get 2021-01-31 23:07:14 -08:00
MoveLevelUp.cs Use IndexOf instead of FindIndex when possible 2021-01-16 12:47:02 -08:00
MoveParseSource.cs Minor clean 2020-12-21 23:37:07 -08:00
MoveTechnicalMachine.cs Add TR flags to emoveset generator 2021-01-30 21:49:45 -08:00
MoveTutor.cs Bake cosplay moves into the encounter template 2021-02-02 09:40:58 -08:00