mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-23 10:53:10 +00:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
66 lines
2.4 KiB
C#
66 lines
2.4 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using static PKHeX.Core.Legal;
|
|
using static PKHeX.Core.GameVersion;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
public static class MoveEgg
|
|
{
|
|
public static int[] GetEggMoves(int species, int form, GameVersion version, int generation)
|
|
{
|
|
if (species > GetMaxSpeciesOrigin(generation, version))
|
|
return Array.Empty<int>();
|
|
|
|
if (!Breeding.CanGameGenerateEggs(version))
|
|
return Array.Empty<int>();
|
|
|
|
return GetEggMoves(generation, species, form, version);
|
|
}
|
|
|
|
public static int[] GetEggMoves(int generation, int species, int form, GameVersion version) => generation switch
|
|
{
|
|
1 or 2 => GetMovesSafe(version == C ? EggMovesC : EggMovesGS, species),
|
|
3 => GetMovesSafe(EggMovesRS, species),
|
|
4 when version is D or P or Pt => GetMovesSafe(EggMovesDPPt, species),
|
|
4 when version is HG or SS => GetMovesSafe(EggMovesHGSS, species),
|
|
5 => GetMovesSafe(EggMovesBW, species),
|
|
|
|
6 when version is X or Y => GetMovesSafe(EggMovesXY, species),
|
|
6 when version is OR or AS => GetMovesSafe(EggMovesAO, species),
|
|
|
|
7 when version is SN or MN => GetFormEggMoves(species, form, EggMovesSM),
|
|
7 when version is US or UM => GetFormEggMoves(species, form, EggMovesUSUM),
|
|
8 when version is SW or SH => GetFormEggMoves(species, form, EggMovesSWSH),
|
|
8 when version is BD or SP => GetMovesSafe(EggMovesBDSP, species),
|
|
_ => Array.Empty<int>(),
|
|
};
|
|
|
|
private static int[] GetMovesSafe<T>(IReadOnlyList<T> moves, int species) where T : EggMoves
|
|
{
|
|
if ((uint)species >= moves.Count)
|
|
return Array.Empty<int>();
|
|
return moves[species].Moves;
|
|
}
|
|
|
|
public static int[] GetFormEggMoves(int species, int form, IReadOnlyList<EggMoves7> table)
|
|
{
|
|
if ((uint)species >= table.Count)
|
|
return Array.Empty<int>();
|
|
|
|
var entry = table[species];
|
|
if (form <= 0 || entry.FormTableIndex <= species)
|
|
return entry.Moves;
|
|
|
|
// Sanity check form in the event it is out of range.
|
|
var baseIndex = entry.FormTableIndex;
|
|
var index = baseIndex + form - 1;
|
|
if ((uint)index >= table.Count)
|
|
return Array.Empty<int>();
|
|
entry = table[index];
|
|
if (entry.FormTableIndex != baseIndex)
|
|
return Array.Empty<int>();
|
|
|
|
return entry.Moves;
|
|
}
|
|
}
|