mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-18 16:33:24 +00:00
02420d3e93
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
70 lines
No EOL
2.3 KiB
C#
70 lines
No EOL
2.3 KiB
C#
using System;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class MysteryBlock7 : SaveBlock
|
|
{
|
|
private const int FlagStart = 0;
|
|
private const int MaxReceivedFlag = 2048;
|
|
private const int MaxCardsPresent = 48;
|
|
// private const int FlagRegionSize = (MaxReceivedFlag / 8); // 0x100
|
|
private const int CardStart = FlagStart + (MaxReceivedFlag / 8);
|
|
|
|
public MysteryBlock7(SAV7SM sav, int offset) : base(sav) => Offset = offset;
|
|
public MysteryBlock7(SAV7USUM sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
// Mystery Gift
|
|
public bool[] MysteryGiftReceivedFlags
|
|
{
|
|
get => ArrayUtil.GitBitFlagArray(Data, Offset + FlagStart, MaxReceivedFlag);
|
|
set
|
|
{
|
|
if (value?.Length != MaxReceivedFlag)
|
|
return;
|
|
ArrayUtil.SetBitFlagArray(Data, Offset + FlagStart, value);
|
|
SAV.Edited = true;
|
|
}
|
|
}
|
|
|
|
public DataMysteryGift[] MysteryGiftCards
|
|
{
|
|
get
|
|
{
|
|
var cards = new DataMysteryGift[MaxCardsPresent];
|
|
for (int i = 0; i < cards.Length; i++)
|
|
cards[i] = GetGift(i);
|
|
return cards;
|
|
}
|
|
set
|
|
{
|
|
int count = Math.Min(MaxCardsPresent, value.Length);
|
|
for (int i = 0; i < count; i++)
|
|
SetGift((WC7)value[i], i);
|
|
for (int i = value.Length; i < MaxCardsPresent; i++)
|
|
SetGift(new WC7(), i);
|
|
}
|
|
}
|
|
|
|
private WC7 GetGift(int index)
|
|
{
|
|
if ((uint)index > MaxCardsPresent)
|
|
throw new ArgumentOutOfRangeException(nameof(index));
|
|
|
|
var offset = GetGiftOffset(index);
|
|
var data = SAV.GetData(offset, WC7.Size);
|
|
return new WC7(data);
|
|
}
|
|
|
|
private int GetGiftOffset(int index) => Offset + CardStart + (index * WC7.Size);
|
|
|
|
private void SetGift(WC7 wc7, int index)
|
|
{
|
|
if ((uint)index > MaxCardsPresent)
|
|
throw new ArgumentOutOfRangeException(nameof(index));
|
|
if (wc7.Data.Length != WC7.Size)
|
|
throw new InvalidCastException(nameof(wc7));
|
|
|
|
SAV.SetData(wc7.Data, GetGiftOffset(index));
|
|
}
|
|
}
|
|
} |