mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-26 22:10:21 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface. |
||
|---|---|---|
| .. | ||
| BallBrowser.cs | ||
| BallBrowser.Designer.cs | ||
| CatchRate.cs | ||
| CatchRate.Designer.cs | ||
| ContestStat.cs | ||
| ContestStat.Designer.cs | ||
| ContextMenuPKM.cs | ||
| ContextMenuPKM.Designer.cs | ||
| DrawConfig.cs | ||
| EditPK1.cs | ||
| EditPK2.cs | ||
| EditPK3.cs | ||
| EditPK4.cs | ||
| EditPK5.cs | ||
| EditPK6.cs | ||
| EditPK7.cs | ||
| EditPK8.cs | ||
| FormArgument.cs | ||
| FormArgument.Designer.cs | ||
| IMainEditor.cs | ||
| LoadSave.cs | ||
| PKMEditor.cs | ||
| PKMEditor.Designer.cs | ||
| PKMEditor.resx | ||
| ShinyLeaf.cs | ||
| ShinyLeaf.Designer.cs | ||
| ShinyLeaf.resx | ||
| SizeCP.cs | ||
| SizeCP.Designer.cs | ||
| StatEditor.cs | ||
| StatEditor.Designer.cs | ||
| TrainerID.cs | ||
| TrainerID.Designer.cs | ||