mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-18 08:23:12 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
50 lines
1.3 KiB
C#
50 lines
1.3 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public abstract class Entralink5 : SaveBlock
|
|
{
|
|
protected Entralink5(SAV5 SAV, int offset) : base(SAV) => Offset = offset;
|
|
|
|
public ushort WhiteForestLevel
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x0C));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x0C), value);
|
|
}
|
|
|
|
public ushort BlackCityLevel
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x0E));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x0E), value);
|
|
}
|
|
}
|
|
|
|
public sealed class Entralink5BW : Entralink5
|
|
{
|
|
public Entralink5BW(SAV5BW SAV, int offset) : base(SAV, offset) { }
|
|
}
|
|
|
|
public sealed class Entralink5B2W2 : Entralink5
|
|
{
|
|
public Entralink5B2W2(SAV5B2W2 SAV, int offset) : base(SAV, offset) { }
|
|
|
|
public byte PassPower1
|
|
{
|
|
get => Data[Offset + 0x1A0];
|
|
set => Data[Offset + 0x1A0] = value;
|
|
}
|
|
|
|
public byte PassPower2
|
|
{
|
|
get => Data[Offset + 0x1A1];
|
|
set => Data[Offset + 0x1A1] = value;
|
|
}
|
|
|
|
public byte PassPower3
|
|
{
|
|
get => Data[Offset + 0x1A2];
|
|
set => Data[Offset + 0x1A2] = value;
|
|
}
|
|
}
|
|
}
|