PKHeX/PKHeX.Core/Legality
Kurt 47071b41f3
Refactoring: Span-based value writes and method signatures (#3361)
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-02 21:35:59 -08:00
..
Areas Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
Encounters Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
Enums Condense some expressions 2021-08-22 01:26:28 -07:00
Evolutions Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
Formatting Add contest stat sheen checking 2021-12-07 00:54:39 -08:00
Learnset Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
Moves Temp handling for bdsp case 2021-12-09 19:53:43 -08:00
Restrictions Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
RNG Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
Structures Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
Tables Unban alternate Lake Verity zone 2021-12-28 17:26:05 -05:00
Verifiers Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
BinLinker.cs Span-ify the unpacking of mini arcs 2021-12-20 18:37:45 -08:00
Breeding.cs Update 21.11.19 - Brilliant Diamond & Shining Pearl (#3289) 2021-11-19 18:23:49 -08:00
BulkAnalysis.cs More records/sealing 2021-12-05 23:54:59 -08:00
BulkGenerator.cs Unify concepts with different names 2020-12-10 20:42:30 -08:00
Core.cs Remove trailing whitespace 2021-12-27 14:03:41 -08:00
LegalityAnalysis.cs Remove unnecessary warning suppression 2021-12-27 12:09:15 -08:00
LegalityAnalyzers.cs Split Trainer verifier into TrainerName and TrainerID 2021-11-25 19:15:42 -08:00
MoveList.cs Fix dropdown suggested green moves from showing swsh moves 2021-11-23 22:58:41 -08:00
MoveListSuggest.cs Fix dropdown suggested green moves from showing swsh moves 2021-11-23 22:58:41 -08:00