mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-24 19:33:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
33 lines
No EOL
883 B
C#
33 lines
No EOL
883 B
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class Misc8 : SaveBlock
|
|
{
|
|
public Misc8(SAV8SWSH sav, SCBlock block) : base(sav, block.Data) { }
|
|
|
|
public int Badges
|
|
{
|
|
get => Data[Offset + 0x00];
|
|
set => Data[Offset + 0x00] = (byte)value;
|
|
}
|
|
|
|
public uint Money
|
|
{
|
|
get => ReadUInt32LittleEndian(Data.AsSpan(Offset + 0x04));
|
|
set
|
|
{
|
|
if (value > 9999999)
|
|
value = 9999999;
|
|
WriteUInt32LittleEndian(Data.AsSpan(Offset + 0x04), value);
|
|
}
|
|
}
|
|
|
|
public int BP
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x11C));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x11C), (ushort)value);
|
|
}
|
|
}
|
|
} |