PKHeX/PKHeX.Core/Saves/Substructures/Gen8/HallOfFameTime8.cs
Kurt 47071b41f3
Refactoring: Span-based value writes and method signatures (#3361)
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-02 21:35:59 -08:00

41 lines
1.2 KiB
C#

using System;
using System.Diagnostics;
using System.ComponentModel;
using static System.Buffers.Binary.BinaryPrimitives;
namespace PKHeX.Core
{
public sealed class HallOfFameTime8 : SaveBlock
{
public HallOfFameTime8(SAV8SWSH sav, SCBlock block) : base(sav, block.Data)
{
Debug.Assert(Data.Length == 8);
}
private const string General = nameof(General);
[Category(General), Description("Raw amount of seconds since 1970 (Unix Timestamp)")]
public long TimeStamp
{
get => ReadInt64LittleEndian(Data.AsSpan(Offset + 0));
set => WriteInt64LittleEndian(Data.AsSpan(Offset), value);
}
[Category(General), Description("Date and Time (UTC) the player entered the Hall Of Fame")]
public DateTime Date
{
get
{
var epoch = new DateTime(1970, 1, 1);
var date = epoch.AddSeconds(TimeStamp);
return date;
}
set
{
var epoch = new DateTime(1970, 1, 1);
var delta = value.Subtract(epoch);
TimeStamp = (long)delta.TotalSeconds;
}
}
}
}