mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-24 19:33:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
46 lines
1.4 KiB
C#
46 lines
1.4 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Gen3 <see cref="GameVersion.RSBOX"/> Block Info
|
|
/// </summary>
|
|
public sealed class BlockInfoRSBOX : BlockInfo
|
|
{
|
|
public readonly uint SaveCount;
|
|
public readonly uint OriginalChecksum;
|
|
private const int ChecksumRegionSize = 0x1FF8;
|
|
|
|
public BlockInfoRSBOX(ReadOnlySpan<byte> data, int offset)
|
|
{
|
|
Offset = offset;
|
|
Length = 4 + ChecksumRegionSize;
|
|
|
|
// Values stored in Big Endian format
|
|
OriginalChecksum = ReadUInt32BigEndian(data[Offset..]);
|
|
ID = ReadUInt32BigEndian(data[(Offset + 4)..]);
|
|
SaveCount = ReadUInt32BigEndian(data[(Offset + 8)..]);
|
|
}
|
|
|
|
protected override bool ChecksumValid(Span<byte> data)
|
|
{
|
|
var chk = GetChecksum(data);
|
|
var old = ReadUInt32BigEndian(data[Offset..]);
|
|
return chk == old;
|
|
}
|
|
|
|
protected override void SetChecksum(Span<byte> data)
|
|
{
|
|
var chk = GetChecksum(data);
|
|
var span = data[Offset..];
|
|
WriteUInt32BigEndian(span, chk);
|
|
}
|
|
|
|
private uint GetChecksum(Span<byte> data)
|
|
{
|
|
var span = data.Slice(Offset + 4, ChecksumRegionSize);
|
|
return Checksums.CheckSum16BigInvert(span);
|
|
}
|
|
}
|
|
}
|