mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-23 10:53:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
61 lines
1.7 KiB
C#
61 lines
1.7 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class Situation6 : SaveBlock
|
|
{
|
|
public Situation6(SaveFile SAV, int offset) : base(SAV) => Offset = offset;
|
|
|
|
public int M
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x02));
|
|
set
|
|
{
|
|
var span = Data.AsSpan(Offset + 0x02);
|
|
WriteUInt16LittleEndian(span, (ushort)value);
|
|
WriteUInt16LittleEndian(span[0xF4..], (ushort)value);
|
|
}
|
|
}
|
|
|
|
public float X
|
|
{
|
|
get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x10)) / 18;
|
|
set
|
|
{
|
|
var span = Data.AsSpan(Offset + 0x10);
|
|
WriteSingleLittleEndian(span, value * 18);
|
|
WriteSingleLittleEndian(span[0xF4..], value * 18);
|
|
}
|
|
}
|
|
|
|
public float Z
|
|
{
|
|
get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x14));
|
|
set
|
|
{
|
|
var span = Data.AsSpan(Offset + 0x14);
|
|
WriteSingleLittleEndian(span, value * 18);
|
|
WriteSingleLittleEndian(span[0xF4..], value * 18);
|
|
}
|
|
}
|
|
|
|
public float Y
|
|
{
|
|
get => ReadSingleLittleEndian(Data.AsSpan(Offset + 0x18)) / 18;
|
|
set
|
|
{
|
|
var span = Data.AsSpan(Offset + 0x18);
|
|
WriteSingleLittleEndian(span, value * 18);
|
|
WriteSingleLittleEndian(span[0xF4..], value * 18);
|
|
}
|
|
}
|
|
|
|
// xy only
|
|
public int Style
|
|
{
|
|
get => Data[Offset + 0x14D];
|
|
set => Data[Offset + 0x14D] = (byte)value;
|
|
}
|
|
}
|
|
}
|