mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-23 10:53:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
35 lines
942 B
C#
35 lines
942 B
C#
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public abstract class BattleVideo : IPokeGroup
|
|
{
|
|
public abstract IReadOnlyList<PKM> BattlePKMs { get; }
|
|
public abstract int Generation { get; }
|
|
|
|
public IEnumerable<PKM> Contents => BattlePKMs;
|
|
|
|
public static BattleVideo? GetVariantBattleVideo(byte[] data)
|
|
{
|
|
if (BV6.IsValid(data))
|
|
return new BV6(data);
|
|
if (BV7.IsValid(data))
|
|
return new BV7(data);
|
|
if (BV3.IsValid(data))
|
|
return new BV3(data);
|
|
return null;
|
|
}
|
|
|
|
public static bool IsValid(ReadOnlySpan<byte> data)
|
|
{
|
|
if (BV6.IsValid(data))
|
|
return true;
|
|
if (BV7.IsValid(data))
|
|
return true;
|
|
if (BV3.IsValid(data))
|
|
return true;
|
|
return false;
|
|
}
|
|
}
|
|
}
|