mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-18 00:13:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
37 lines
1.4 KiB
C#
37 lines
1.4 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// <see cref="PersonalInfo"/> class with values from the Sun & Moon games.
|
|
/// </summary>
|
|
public class PersonalInfoSM : PersonalInfoXY
|
|
{
|
|
public new const int SIZE = 0x54;
|
|
|
|
public PersonalInfoSM(byte[] data) : base(data)
|
|
{
|
|
TMHM = GetBits(Data.AsSpan(0x28, 0x10)); // 36-39
|
|
TypeTutors = GetBits(Data.AsSpan(0x38, 0x4)); // 40
|
|
|
|
SpecialTutors = new[]
|
|
{
|
|
GetBits(Data.AsSpan(0x3C, 0x0A)),
|
|
};
|
|
}
|
|
|
|
public override byte[] Write()
|
|
{
|
|
SetBits(TMHM, Data.AsSpan(0x28));
|
|
SetBits(TypeTutors, Data.AsSpan(0x38));
|
|
SetBits(SpecialTutors[0], Data.AsSpan(0x3C));
|
|
return Data;
|
|
}
|
|
|
|
public int SpecialZ_Item { get => ReadUInt16LittleEndian(Data.AsSpan(0x4C)); set => WriteUInt16LittleEndian(Data.AsSpan(0x4C), (ushort)value); }
|
|
public int SpecialZ_BaseMove { get => ReadUInt16LittleEndian(Data.AsSpan(0x4E)); set => WriteUInt16LittleEndian(Data.AsSpan(0x4E), (ushort)value); }
|
|
public int SpecialZ_ZMove { get => ReadUInt16LittleEndian(Data.AsSpan(0x50)); set => WriteUInt16LittleEndian(Data.AsSpan(0x50), (ushort)value); }
|
|
public bool LocalVariant { get => Data[0x52] == 1; set => Data[0x52] = value ? (byte)1 : (byte)0; }
|
|
}
|
|
}
|