PKHeX/PKHeX.Core/Legality/Areas
Kurt 47071b41f3
Refactoring: Span-based value writes and method signatures (#3361)
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to.

`System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API.

The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder.

Other Fixes included:
- The Super Training UI for Gen6 has been reworked according to the latest block structure additions.
- Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list).
- Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-02 21:35:59 -08:00
..
EncounterArea.cs Minor clean 2021-12-04 17:56:56 -08:00
EncounterArea1.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea2.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea3.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea3XD.cs Revise EncounterArea and EncounterType for clarity (#3228) 2021-06-29 20:58:06 -07:00
EncounterArea4.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea5.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea6AO.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea6XY.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea7.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea7b.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea7g.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea8.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea8b.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00
EncounterArea8g.cs Refactoring: Span-based value writes and method signatures (#3361) 2022-01-02 21:35:59 -08:00