PKHeX/PKHeX.Core/Legality
Kurt d1cfdd782e Rework ball / frame check passing
Two checks are performed for Gen 3 & 4:
A: Encounterability (wurmple, ball, ability)
B: RNG Compatibility (frame)

Original code only checked 'A'
Recent code ordered by 'A', but returned anything that matched 'B'. If
'B was not satisfied, an 'A' match would get deferred, allowing for an
eventual B & !A to be returned before a A & !B being returned.

yay bool logic

we want to prefer a RNGFrameMatch as well as a SlotCompatible match
original code (no RNG checks) retrieves with SlotCompatible just fine
recent adding in framematch resulted in deferring compatible if not RNG
frame, yielding !A matches before A & !B

maintain 3 queues (A & B get yielded immediately) to track A!B, !AB, and
!A!B
not necessary to check unown case anymore as it'll fall into the A!B
group. better performant to skip that check in favor of only adding for
fail.

thanks theSlayer!
2018-03-21 20:19:54 -07:00
..
Areas Reorganization 2018-03-05 20:49:45 -08:00
Encounters Rework ball / frame check passing 2018-03-21 20:19:54 -07:00
Enums Reorganization 2018-03-05 20:49:45 -08:00
Evolutions Reorganization 2018-03-05 20:49:45 -08:00
Learnset Refactoring 2018-03-08 21:18:32 -08:00
Moves Update gen2 egg generator 2018-01-30 20:36:22 -08:00
Ribbons Refactoring 2017-12-11 16:01:24 -08:00
RNG Merge PIDType and bool? shiny property 2018-03-16 19:35:55 -07:00
Structures Fix KChart errors 2018-03-18 11:22:20 -07:00
Analysis.cs Split up IEncounterable generators 2018-03-10 19:51:09 -08:00
Checks.cs Merge PIDType and bool? shiny property 2018-03-16 19:35:55 -07:00
Core.cs Refactoring 2018-03-08 21:18:32 -08:00
Data.cs Refactoring 2017-06-17 18:37:19 -07:00
LegalityCheckStrings.cs Allow pay day mewtwo, disallow dizzy punch 2018-01-25 19:17:42 -08:00
Tables.cs Add Italian to gb languages 2018-01-30 20:34:11 -08:00
Tables1.cs misc tweaks 2017-11-22 21:45:30 -08:00
Tables2.cs Add transfer2 future evos for legality reuse 2018-02-11 20:48:36 -08:00
Tables3.cs Refactoring 2017-12-27 16:36:24 -08:00
Tables4.cs Refactoring 2017-12-27 16:36:24 -08:00
Tables5.cs Change lookup arrays to hashsets 2017-10-17 22:06:07 -07:00
Tables6.cs Misc perf tweaks 2017-12-13 16:12:53 -08:00
Tables7.cs Ban hidden-apricorn voltorb bronzor 2018-03-14 08:10:12 -07:00
VivillonTables.cs add more pkhex.core xml documentation 2017-10-23 23:12:58 -07:00
WordFilter.cs add more pkhex.core xml documentation 2017-10-23 23:12:58 -07:00