mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-23 02:43:13 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
27 lines
No EOL
1.1 KiB
C#
27 lines
No EOL
1.1 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class FieldMenu7 : SaveBlock
|
|
{
|
|
public FieldMenu7(SAV7SM sav, int offset) : base(sav) => Offset = offset;
|
|
public FieldMenu7(SAV7USUM sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
// USUM ONLY
|
|
public ushort RotomAffection
|
|
{
|
|
get => ReadUInt16LittleEndian(SAV.Data.AsSpan(Offset + 0x1A));
|
|
set => WriteUInt16LittleEndian(SAV.Data.AsSpan(Offset + 0x1A), Math.Min((ushort)1000, value));
|
|
}
|
|
|
|
public bool RotomLoto1 { get => (SAV.Data[Offset + 0x2A] & 1) == 1; set => SAV.Data[Offset + 0x2A] = (byte)((SAV.Data[Offset + 0x2A] & ~1) | (value ? 1 : 0)); }
|
|
public bool RotomLoto2 { get => (SAV.Data[Offset + 0x2A] & 2) == 2; set => SAV.Data[Offset + 0x2A] = (byte)((SAV.Data[Offset + 0x2A] & ~2) | (value ? 2 : 0)); }
|
|
|
|
public string RotomOT
|
|
{
|
|
get => SAV.GetString(Offset + 0x30, 0x1A);
|
|
set => SAV.SetString(Data.AsSpan(Offset + 0x30, 0x1A), value.AsSpan(), SAV.OTLength, StringConverterOption.ClearZero);
|
|
}
|
|
}
|
|
} |