mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-23 02:43:13 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
37 lines
No EOL
981 B
C#
37 lines
No EOL
981 B
C#
using System;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class PokeBlock3Case
|
|
{
|
|
private const int Count = 40;
|
|
public readonly PokeBlock3[] Blocks;
|
|
|
|
public PokeBlock3Case(ReadOnlySpan<byte> data, int offset)
|
|
{
|
|
Blocks = new PokeBlock3[Count];
|
|
for (int i = 0; i < Blocks.Length; i++)
|
|
Blocks[i] = PokeBlock3.GetBlock(data, offset + (i * PokeBlock3.SIZE));
|
|
}
|
|
|
|
public byte[] Write()
|
|
{
|
|
byte[] result = new byte[Count*PokeBlock3.SIZE];
|
|
for (int i = 0; i < Blocks.Length; i++)
|
|
Blocks[i].SetBlock(result, i * PokeBlock3.SIZE);
|
|
return result;
|
|
}
|
|
|
|
public void DeleteAll()
|
|
{
|
|
foreach (var b in Blocks)
|
|
b.Delete();
|
|
}
|
|
|
|
public void MaximizeAll(bool createMissing = false)
|
|
{
|
|
foreach (var b in Blocks)
|
|
b.Maximize(createMissing);
|
|
}
|
|
}
|
|
} |