mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
34 lines
1.2 KiB
C#
34 lines
1.2 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// XY specific features for <see cref="MyStatus6"/>
|
|
/// </summary>
|
|
/// <remarks>These properties are technically included in OR/AS but they are unused; assumed backwards compatibility for communications with XY</remarks>
|
|
public sealed class MyStatus6XY : MyStatus6
|
|
{
|
|
public MyStatus6XY(SaveFile sav, int offset) : base(sav, offset) { }
|
|
|
|
public TrainerFashion6 Fashion
|
|
{
|
|
get => TrainerFashion6.GetFashion(SAV.Data, Offset + 0x30, SAV.Gender);
|
|
set => value.Write(Data, Offset + 0x30);
|
|
}
|
|
|
|
private Span<byte> Nickname_Trash => Data.AsSpan(Offset + 0x62, SAV6.ShortStringLength);
|
|
|
|
public string OT_Nick
|
|
{
|
|
get => SAV.GetString(Nickname_Trash);
|
|
set => SAV.SetString(Nickname_Trash, value.AsSpan(), 12, StringConverterOption.ClearZero);
|
|
}
|
|
|
|
public short EyeColor
|
|
{
|
|
get => ReadInt16LittleEndian(Data.AsSpan(Offset + 0x148));
|
|
set => WriteInt16LittleEndian(Data.AsSpan(Offset + 0x148), value);
|
|
}
|
|
}
|
|
}
|