mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-23 20:43:07 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
36 lines
No EOL
1.2 KiB
C#
36 lines
No EOL
1.2 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class LinkBlock6 : SaveBlock
|
|
{
|
|
public LinkBlock6(SAV6XY sav, int offset) : base(sav) => Offset = offset;
|
|
public LinkBlock6(SAV6AO sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
public byte[] GetLinkInfoData() => Data.Slice(Offset + 0x1FF, PL6.Size);
|
|
public PL6 GetLinkInfo() => new(GetLinkInfoData());
|
|
|
|
public void SetLinkInfoData(ReadOnlySpan<byte> data)
|
|
{
|
|
data.CopyTo(Data.AsSpan(Offset));
|
|
Checksum = GetCalculatedChecksum(); // [app,chk)
|
|
}
|
|
|
|
public void SetLinkInfo(PL6 pl6)
|
|
{
|
|
pl6.Data.CopyTo(Data, Offset + 0x1FF);
|
|
Checksum = GetCalculatedChecksum(); // [app,chk)
|
|
}
|
|
|
|
private ushort GetCalculatedChecksum() => Checksums.CRC16_CCITT(new ReadOnlySpan<byte>(Data, Offset + 0x200, 0xC48 - 4 - 0x200)); // [app,chk)
|
|
|
|
private int GetChecksumOffset() => Offset + 0xC48 - 4;
|
|
|
|
public ushort Checksum
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(GetChecksumOffset()));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(GetChecksumOffset()), value);
|
|
}
|
|
}
|
|
} |