mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
55 lines
1.8 KiB
C#
55 lines
1.8 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class ItemInfo6 : SaveBlock
|
|
{
|
|
public ItemInfo6(SaveFile sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
private const int BoundItemCount = 4;
|
|
private const int RecentItemCount = 12;
|
|
|
|
public int[] SelectItems
|
|
{
|
|
// UP,RIGHT,DOWN,LEFT
|
|
get
|
|
{
|
|
var span = Data.AsSpan(Offset + 10);
|
|
int[] list = new int[BoundItemCount];
|
|
for (int i = 0; i < list.Length; i++)
|
|
list[i] = ReadUInt16LittleEndian(span[(2 * i)..]);
|
|
return list;
|
|
}
|
|
set
|
|
{
|
|
if (value.Length != BoundItemCount)
|
|
throw new ArgumentException(nameof(value));
|
|
var span = Data.AsSpan(Offset + 10);
|
|
for (int i = 0; i < value.Length; i++)
|
|
WriteUInt16LittleEndian(span[(2 * i)..], (ushort)value[i]);
|
|
}
|
|
}
|
|
|
|
public int[] RecentItems
|
|
{
|
|
// Items recently interacted with (Give, Use)
|
|
get
|
|
{
|
|
var span = Data.AsSpan(Offset + 20);
|
|
int[] list = new int[RecentItemCount];
|
|
for (int i = 0; i < list.Length; i++)
|
|
list[i] = ReadUInt16LittleEndian(span[(2 * i)..]);
|
|
return list;
|
|
}
|
|
set
|
|
{
|
|
if (value.Length != RecentItemCount)
|
|
throw new ArgumentException(nameof(value));
|
|
var span = Data.AsSpan(Offset + 20);
|
|
for (int i = 0; i < value.Length; i++)
|
|
WriteUInt16LittleEndian(span[(2 * i)..], (ushort)value[i]);
|
|
}
|
|
}
|
|
}
|
|
}
|