PKHeX/Tests/PKHeX.Core.Tests/Legality/Illegal/Ribbons
Kurt 416f5fe183 Check Winning/Victory ribbons for gen3 origin based on encounter
Closes #2990 ty @Atrius97 !

Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly.

Rewrite the national ribbon check for clarity
Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon.

Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.
2020-09-18 16:23:17 -07:00
..
Illegal (has 8 out of 8 Battle Memory).pk7 Check Winning/Victory ribbons for gen3 origin based on encounter 2020-09-18 16:23:17 -07:00
Illegal (has Winning Ribbon).ck3 Check Winning/Victory ribbons for gen3 origin based on encounter 2020-09-18 16:23:17 -07:00