mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 22:40:22 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
30 lines
929 B
C#
30 lines
929 B
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// <see cref="PersonalInfo"/> class with values from Generation 4 games.
|
|
/// </summary>
|
|
public sealed class PersonalInfoG4 : PersonalInfoG3
|
|
{
|
|
public new const int SIZE = 0x2C;
|
|
|
|
public PersonalInfoG4(byte[] data) : base(data)
|
|
{
|
|
// Unpack TMHM & Tutors
|
|
TMHM = GetBits(Data.AsSpan(0x1C, 0x0D));
|
|
//TypeTutors = Array.Empty<bool>(); // not stored in personal -- default value
|
|
}
|
|
|
|
public override byte[] Write()
|
|
{
|
|
SetBits(TMHM, Data.AsSpan(0x1C));
|
|
return Data;
|
|
}
|
|
|
|
// Manually added attributes
|
|
public override int FormCount { get => Data[0x29]; set {} }
|
|
protected internal override int FormStatsIndex { get => ReadUInt16LittleEndian(Data.AsSpan(0x2A)); set {} }
|
|
}
|
|
}
|