mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-15 08:47:14 +00:00
1e86fdcea8
## Issue We want to discard-but-remember any slots that aren't a perfect fit, on the off chance that a better one exists later in the search space. If there's no better match, then we gotta go with what we got. ## Example: Wurmple exists in area `X`, and also has a more rare slot for Silcoon, with the same level for both slots. * We have a Silcoon that we've leveled up a few times. Was our Silcoon originally a Wurmple, or was it caught as a Silcoon? * To be sure, we have to check the EC/PID if the Wurmple wouldn't evolve into Cascoon instead. * We don't want to wholly reject that Wurmple slot, as maybe the Met Level isn't within Silcoon's slot range. --- Existing implementation would store "deferred" matches in a list; we only need to keep 1 of these matches around (less allocation!). We also want to differentiate between a "good" deferral and a "bad" deferral; I don't think this is necessary but it's currently used by Mystery Gift matching (implemented for the Eeveelution mystery gifts which matter for evolution moves). The existing logic didn't use inheritance, and instead had static methods being reused across generations. Quite kludgy. Also, the existing logic was a pain to modify the master encounter yield methods, as one generation's quirks had to not impact all other generations that used the method. --- The new implementation splits out the encounter yielding methods to be separate for each generation / subset. Now, things don't have to check `WasLink` for Gen7 origin, because Pokémon Link wasn't a thing in Gen7. --- ## Future Maybe refactoring yielders into "GameCores" that expose yielding behaviors / properties, rather than the static logic. As more generations and side-gamegroups get added (thanks LGPE/GO/GameCube), all this switch stuff gets annoying to maintain instead of just overriding/inheritance. ## Conclusion This shouldn't impact any legality results negatively; if you notice any regressions, report them! This should reduce false flags where we didn't defer-discard an encounter when we should have (wild area mons being confused with raids).
81 lines
3.4 KiB
C#
81 lines
3.4 KiB
C#
using System.Linq;
|
|
using static PKHeX.Core.LegalityCheckStrings;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Verifies the <see cref="PKM.EVs"/>.
|
|
/// </summary>
|
|
public sealed class EffortValueVerifier : Verifier
|
|
{
|
|
protected override CheckIdentifier Identifier => CheckIdentifier.EVs;
|
|
|
|
public override void Verify(LegalityAnalysis data)
|
|
{
|
|
var pkm = data.pkm;
|
|
if (pkm is IAwakened a)
|
|
{
|
|
VerifyAwakenedValues(data, a);
|
|
return;
|
|
}
|
|
var enc = data.EncounterMatch;
|
|
int sum = pkm.EVTotal;
|
|
if (sum > 0 && pkm.IsEgg)
|
|
data.AddLine(GetInvalid(LEffortEgg));
|
|
|
|
// In Generations I and II, when a Pokémon is taken out of the Day Care, its experience will lower to the minimum value for its current level.
|
|
int format = pkm.Format;
|
|
if (format < 3) // can abuse daycare for EV training without EXP gain
|
|
return;
|
|
|
|
if (sum > 510) // format >= 3
|
|
data.AddLine(GetInvalid(LEffortAbove510));
|
|
var evs = pkm.EVs;
|
|
if (format >= 6 && evs.Any(ev => ev > 252))
|
|
data.AddLine(GetInvalid(LEffortAbove252));
|
|
|
|
const int vitaMax = 100; // Vitamin Max
|
|
if (format < 5) // 3/4
|
|
{
|
|
if (enc.LevelMin == 100) // only true for Gen4 and Format=4
|
|
{
|
|
// Cannot EV train at level 100 -- Certain events are distributed at level 100.
|
|
if (evs.Any(ev => ev > vitaMax)) // EVs can only be increased by vitamins to a max of 100.
|
|
data.AddLine(GetInvalid(LEffortCap100));
|
|
}
|
|
else // check for gained EVs without gaining EXP -- don't check gen5+ which have wings to boost above 100.
|
|
{
|
|
var growth = PersonalTable.HGSS[enc.Species].EXPGrowth;
|
|
var baseEXP = Experience.GetEXP(enc.LevelMin, growth);
|
|
if (baseEXP == pkm.EXP && evs.Any(ev => ev > vitaMax))
|
|
data.AddLine(GetInvalid(string.Format(LEffortUntrainedCap, vitaMax)));
|
|
}
|
|
}
|
|
|
|
// Only one of the following can be true: 0, 508, and x%6!=0
|
|
if (sum == 0 && !enc.IsWithinEncounterRange(pkm))
|
|
data.AddLine(Get(LEffortEXPIncreased, Severity.Fishy));
|
|
else if (sum == 508)
|
|
data.AddLine(Get(LEffort2Remaining, Severity.Fishy));
|
|
else if (evs[0] != 0 && evs.All(ev => evs[0] == ev))
|
|
data.AddLine(Get(LEffortAllEqual, Severity.Fishy));
|
|
}
|
|
|
|
private void VerifyAwakenedValues(LegalityAnalysis data, IAwakened awakened)
|
|
{
|
|
var pkm = data.pkm;
|
|
int sum = pkm.EVTotal;
|
|
if (sum != 0)
|
|
data.AddLine(GetInvalid(LEffortShouldBeZero));
|
|
|
|
if (!awakened.AwakeningAllValid())
|
|
data.AddLine(GetInvalid(LAwakenedCap));
|
|
|
|
var enc = data.EncounterMatch;
|
|
if (enc is EncounterSlot7GO && Enumerable.Range(0, 6).Select(awakened.GetAV).Any(z => z < 2))
|
|
data.AddLine(GetInvalid(string.Format(LAwakenedShouldBeValue, 2))); // go park transfers have 2 AVs for all stats.
|
|
else if (awakened.AwakeningSum() == 0 && !enc.IsWithinEncounterRange(pkm))
|
|
data.AddLine(Get(LAwakenedEXPIncreased, Severity.Fishy));
|
|
}
|
|
}
|
|
}
|