mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-02 08:49:18 +00:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
25 lines
668 B
C#
25 lines
668 B
C#
namespace PKHeX.Core;
|
|
|
|
public interface IPersonalEgg
|
|
{
|
|
/// <summary>
|
|
/// First Egg Group
|
|
/// </summary>
|
|
int EggGroup1 { get; set; }
|
|
|
|
/// <summary>
|
|
/// Second Egg Group
|
|
/// </summary>
|
|
int EggGroup2 { get; set; }
|
|
}
|
|
|
|
public static class PersonalEggExtensions
|
|
{
|
|
/// <summary>
|
|
/// Checks if the entry has either egg group equal to the input type.
|
|
/// </summary>
|
|
/// <param name="pi">Object reference</param>
|
|
/// <param name="group">Egg group</param>
|
|
/// <returns>Egg is present in entry</returns>
|
|
public static bool IsEggGroup(this IPersonalEgg pi, int group) => pi.EggGroup1 == group || pi.EggGroup2 == group;
|
|
}
|