mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-23 19:03:11 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
62 lines
2.1 KiB
C#
62 lines
2.1 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Generation 4 Evolution Branch Entries
|
|
/// </summary>
|
|
public static class EvolutionSet4
|
|
{
|
|
private static EvolutionMethod GetMethod(ReadOnlySpan<byte> data)
|
|
{
|
|
var method = data[0]; // other byte unnecessary
|
|
int arg = ReadUInt16LittleEndian(data[2..]);
|
|
int species = ReadUInt16LittleEndian(data[4..]);
|
|
|
|
if (method == 0)
|
|
throw new ArgumentOutOfRangeException(nameof(method));
|
|
|
|
// To have the same structure as gen 6
|
|
// Gen 4 Method 6 is Gen 6 Method 7, G4 7 = G6 8, and so on
|
|
if (method > 6)
|
|
method++;
|
|
|
|
var lvl = EvolutionSet6.EvosWithArg.Contains(method) ? 0 : arg;
|
|
return new EvolutionMethod(method, species, argument: arg, level: lvl);
|
|
}
|
|
|
|
public static IReadOnlyList<EvolutionMethod[]> GetArray(ReadOnlySpan<byte> data)
|
|
{
|
|
const int bpe = 6; // bytes per evolution entry
|
|
const int entries = 7; // amount of entries per species
|
|
const int size = (entries * bpe) + 2; // bytes per species entry, + 2 alignment bytes
|
|
|
|
var evos = new EvolutionMethod[data.Length / size][];
|
|
for (int i = 0; i < evos.Length; i++)
|
|
{
|
|
int offset = i * size;
|
|
int count = 0;
|
|
for (; count < entries; count++)
|
|
{
|
|
var methodOffset = offset + (count * bpe);
|
|
var method = data[methodOffset];
|
|
if (method == 0)
|
|
break;
|
|
}
|
|
if (count == 0)
|
|
{
|
|
evos[i] = Array.Empty<EvolutionMethod>();
|
|
continue;
|
|
}
|
|
|
|
var set = new EvolutionMethod[count];
|
|
for (int j = 0; j < set.Length; j++)
|
|
set[j] = GetMethod(data.Slice(offset + (j * bpe), bpe));
|
|
evos[i] = set;
|
|
}
|
|
return evos;
|
|
}
|
|
}
|
|
}
|