PKHeX/PKHeX.Core/Legality
Kurt 0626b0c29b
Add Breeding move ordering logic, and use in legality analysis (#3183)
* Initial bred moveset validation logic

Unpeel the inheritance via recursion and permitted moves

* Volt tackle considerations

* Optimize out empty slot skips

* Add tests, fix off-by-one's

* Require all base moves if empty slot in moveset

* Add test to prove failure per Anubis' provided test

* Tweak enum labels for easier debugging

When two enums share the same underlying value, the ToString/name of the value may be either of the two (or the last defined one, in my debugging). Just give it a separate magic value.

* Fix recursion oopsie

Also check for scenario where no-base-moves but not enough moves to push base moves out

* Add Crystal tutor checks

* Add specialized gen2 verification method

Game loops through father's moves and pushes in one iteration, rather than checking by type.

* Add another case with returning base move

* Add push-out requirement for re-added base moves

* Minor tweaks

Condense tests, fix another off-by-one noticed when creating tests

* Disallow inherited parent levelup moves

Disallow volt tackle on Gen2/R/S

* Split MoveBreed into generation specific classes

Gen2 behaves slightly different from Gen3/4, which behaves slightly different from Gen5... and Gen6 behaves differently too.

Add some xmldoc as the api is starting to solidify

* Add method overload that returns the parse

Verify that the parse order is as expected

* Add reordering suggestion logic

Try sorting first, then go nuclear with rebuilding.

* Return base moves if complete fail

* Set base moves when generating eggs, only.

* Use breed logic to check for egg ordering legality

Don't bother helping for split-breed species
2021-04-04 18:30:01 -07:00
..
Areas More xmldoc 2021-03-23 21:20:02 -07:00
Encounters Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
Enums Add case for special headbutt slots 2021-03-11 20:52:00 -08:00
Evolutions Minor clean 2021-03-14 16:16:55 -07:00
Formatting Show Mystery Gift information in hover summary 2021-03-30 20:27:58 -07:00
Learnset Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
Moves Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
Restrictions More tweaks 2021-02-19 10:52:26 -08:00
RNG Minor clean 2021-03-14 16:16:55 -07:00
Structures Use already allocated result array 2021-03-30 20:27:40 -07:00
Tables Add more xmldoc / enum clean 2021-03-14 11:28:46 -07:00
Verifiers Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
BinLinker.cs Minor clean 2021-03-14 16:16:55 -07:00
Breeding.cs Simplify more expressions 2021-01-04 17:31:43 -08:00
BulkAnalysis.cs More tweaks 2021-02-19 10:52:26 -08:00
BulkGenerator.cs Unify concepts with different names 2020-12-10 20:42:30 -08:00
Core.cs Refactoring 2021-02-03 11:33:09 -08:00
LegalityAnalysis.cs Extract report generation from LegalityAnalysis object functions 2021-03-20 13:21:04 -07:00
LegalityAnalyzers.cs Add more xmldoc / enum clean 2021-03-14 11:28:46 -07:00
MoveList.cs Add more xmldoc / enum clean 2021-03-14 11:28:46 -07:00
MoveListSuggest.cs Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00