mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-01 00:09:14 +00:00
02420d3e93
* Handle some nullable cases
Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization
* Handle bits more obviously without null
* Make SaveFile.BAK explicitly readonly again
* merge constructor methods to have readonly fields
* Inline some properties
* More nullable handling
* Rearrange box actions
define straightforward classes to not have any null properties
* Make extrabyte reference array immutable
* Move tooltip creation to designer
* Rearrange some logic to reduce nesting
* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum
* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case
* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable
* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator
* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever
* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)
* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
56 lines
2.4 KiB
C#
56 lines
2.4 KiB
C#
using System;
|
||
using System.Collections.Generic;
|
||
|
||
namespace PKHeX.Core
|
||
{
|
||
/// <summary>
|
||
/// Generation 7 <see cref="SaveFile"/> object that reads from Pokémon Bank savedata (stored on AWS).
|
||
/// </summary>
|
||
public sealed class Bank7 : BulkStorage
|
||
{
|
||
public Bank7(byte[] data, Type t, int start, int slotsPerBox = 30) : base(data, t, start, slotsPerBox) => Version = GameVersion.USUM;
|
||
|
||
public override PersonalTable Personal => PersonalTable.USUM;
|
||
public override IReadOnlyList<ushort> HeldItems => Legal.HeldItems_SM;
|
||
public override SaveFile Clone() => new Bank7((byte[])Data.Clone(), PKMType, BoxStart, SlotsPerBox);
|
||
public override string PlayTimeString => $"{Year:00}{Month:00}{Day:00}_{Hours:00}ː{Minutes:00}";
|
||
protected override string BAKText => PlayTimeString;
|
||
private const int GroupNameSize = 0x20;
|
||
private const int BankNameSize = 0x24;
|
||
private const int GroupNameSpacing = GroupNameSize + 2;
|
||
private const int BankNameSpacing = BankNameSize + 2;
|
||
|
||
public ulong UID => BitConverter.ToUInt64(Data, 0);
|
||
|
||
public string GetGroupName(int group)
|
||
{
|
||
if ((uint)group > 10)
|
||
throw new ArgumentException($"{nameof(group)} must be 1-10.");
|
||
int offset = 0x8 + (GroupNameSpacing * group) + 2; // skip over " "
|
||
return GetString(offset, GroupNameSize / 2);
|
||
}
|
||
|
||
public override int BoxCount => BankCount;
|
||
|
||
private int BankCount
|
||
{
|
||
get => Data[0x15E];
|
||
set => Data[0x15E] = (byte)value;
|
||
}
|
||
|
||
private int Year => BitConverter.ToUInt16(Data, 0x160);
|
||
private int Month => Data[0x162];
|
||
private int Day => Data[0x163];
|
||
private int Hours => Data[0x164];
|
||
private int Minutes => Data[0x165];
|
||
|
||
private int BoxDataSize => (SlotsPerBox * SIZE_STORED) + BankNameSpacing;
|
||
public override int GetBoxOffset(int box) => Box + (BoxDataSize * box);
|
||
public override string GetBoxName(int box) => GetString(GetBoxNameOffset(box), BankNameSize / 2);
|
||
public int GetBoxNameOffset(int box) => GetBoxOffset(box) + (SlotsPerBox * SIZE_STORED);
|
||
public int GetBoxIndex(int box) => BitConverter.ToUInt16(Data, GetBoxNameOffset(box) + BankNameSize);
|
||
|
||
private const int BoxStart = 0x17C;
|
||
public static Bank7 GetBank7(byte[] data) => new Bank7(data, typeof(PK7), BoxStart);
|
||
}
|
||
}
|