mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-27 14:30:56 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
46 lines
1.4 KiB
C#
46 lines
1.4 KiB
C#
using System;
|
|
using FluentAssertions;
|
|
using PKHeX.Core;
|
|
using Xunit;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Tests.Util;
|
|
|
|
public class FlagUtilTests
|
|
{
|
|
[Theory]
|
|
[InlineData(1, 0, 0)]
|
|
[InlineData(2, 0, 1)]
|
|
[InlineData(0x8000_0000, 3, 7)]
|
|
public void GetSetFlag(uint raw, int byteIndex, int bitIndex)
|
|
{
|
|
Span<byte> data = stackalloc byte[4];
|
|
WriteUInt32LittleEndian(data, raw);
|
|
var value = FlagUtil.GetFlag(data, byteIndex, bitIndex);
|
|
value.Should().Be(true);
|
|
|
|
Span<byte> copy = stackalloc byte[data.Length];
|
|
FlagUtil.SetFlag(copy, byteIndex, bitIndex, true);
|
|
data.SequenceEqual(copy).Should().BeTrue();
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0x7FFF_FFFE, 0, 0)]
|
|
public void ClearFlag(uint raw, int byteIndex, int bitIndex)
|
|
{
|
|
Span<byte> data = stackalloc byte[4];
|
|
WriteUInt32LittleEndian(data, raw);
|
|
var value = FlagUtil.GetFlag(data, byteIndex, bitIndex);
|
|
value.Should().Be(false);
|
|
|
|
// does nothing on empty
|
|
Span<byte> copy = stackalloc byte[data.Length];
|
|
FlagUtil.SetFlag(copy, byteIndex, bitIndex, false);
|
|
copy.Count((byte)0).Should().Be(copy.Length);
|
|
|
|
// doesn't clear any other flag
|
|
data.CopyTo(copy);
|
|
FlagUtil.SetFlag(copy, byteIndex, bitIndex, false);
|
|
data.SequenceEqual(copy).Should().BeTrue();
|
|
}
|
|
}
|