mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-23 20:43:07 +00:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
34 lines
1.4 KiB
C#
34 lines
1.4 KiB
C#
using System;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Group that checks the source of a move in the games that it represents.
|
|
/// </summary>
|
|
public interface IEvolutionGroup
|
|
{
|
|
/// <summary>
|
|
/// Gets the previous (backward) generation group to traverse to continue processing.
|
|
/// </summary>
|
|
IEvolutionGroup? GetPrevious(PKM pk, EvolutionOrigin enc);
|
|
|
|
/// <summary>
|
|
/// Gets the next (forward) generation group to traverse to continue processing.
|
|
/// </summary>
|
|
IEvolutionGroup? GetNext(PKM pk, EvolutionOrigin enc);
|
|
|
|
bool Append(PKM pk, EvolutionHistory history, ref ReadOnlySpan<EvoCriteria> chain, EvolutionOrigin enc);
|
|
|
|
EvoCriteria[] GetInitialChain(PKM pk, EvolutionOrigin enc, ushort species, byte form);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Details about the original encounter.
|
|
/// </summary>
|
|
/// <param name="Species">Species the encounter originated as</param>
|
|
/// <param name="Version">Version the encounter originated on</param>
|
|
/// <param name="Generation">Generation the encounter originated in</param>
|
|
/// <param name="LevelMin">Minimum level the encounter originated at</param>
|
|
/// <param name="LevelMax">Maximum level in final state</param>
|
|
/// <param name="SkipChecks">Skip enforcement of legality for evolution criteria</param>
|
|
public readonly record struct EvolutionOrigin(ushort Species, byte Version, byte Generation, byte LevelMin, byte LevelMax, bool SkipChecks = false);
|